prop/lib/microwaveprop_web/controllers/beacon_monitor_controller.ex
Graham McIntire fd976b0cd5
fix: resolve 391 Credo issues across codebase
- Add jump_credo_checks ~> 0.4 with all 20 checks enabled
- Fix all standard Credo issues: 139 @spec (113 done, 26 remain),
  4 refactoring, 3 alias usage, 9 System.cmd env, 5 unsafe_to_atom,
  2 max line length, 9 assert_receive timeout
- Fix 170+ jump_credo_checks warnings:
  - 117 TopLevelAliasImportRequire: move nested alias/import to module top
  - 32 UseObanProWorker: switch to Oban.Pro.Worker
  - 4 DoctestIExExamples: add doctests / create test file
  - ~20 WeakAssertion: strengthen type-check assertions
  - Various ConditionalAssertion, AssertReceiveTimeout fixes
- Exclude vendor/ from Credo analysis
- Remaining: 175 warnings (mostly opinionated WeakAssertion,
  AvoidSocketAssignsInTest), 26 @spec annotations
2026-06-12 13:51:32 -05:00

40 lines
1.3 KiB
Elixir

defmodule MicrowavepropWeb.BeaconMonitorController do
use MicrowavepropWeb, :controller
alias Microwaveprop.BeaconMonitors
@spec create(Plug.Conn.t(), map()) :: Plug.Conn.t()
def create(conn, %{"beacon_monitor" => params}) do
user = conn.assigns.current_scope.user
case BeaconMonitors.create_monitor(user, params) do
{:ok, monitor} ->
conn
|> put_flash(:info, "Monitor '#{monitor.name}' created. Copy its token below.")
|> redirect(to: ~p"/users/settings")
{:error, changeset} ->
message =
changeset
|> Ecto.Changeset.traverse_errors(fn {msg, _} -> msg end)
|> Enum.map_join("; ", fn {k, v} -> "#{k}: #{Enum.join(v, ", ")}" end)
conn
|> put_flash(:error, "Could not create monitor (#{message}).")
|> redirect(to: ~p"/users/settings")
end
end
@spec delete(Plug.Conn.t(), map()) :: Plug.Conn.t()
def delete(conn, %{"id" => id}) do
user = conn.assigns.current_scope.user
conn =
case BeaconMonitors.delete_monitor(user, id) do
{:ok, _monitor} -> put_flash(conn, :info, "Monitor deleted.")
{:error, :not_found} -> put_flash(conn, :error, "Monitor not found.")
end
redirect(conn, to: ~p"/users/settings")
end
end