Graham McIntire
d61fbd346e
Enabled :error_handling, :unknown, :unmatched_returns, :extra_return, :missing_return in an earlier commit and landed a 129-warning baseline. Four parallel agents each fixed a directory slice: - Core contexts (29): Radio, Release, Weather, Beacons, Cache, Backtest.Features, Terrain.Srtm, Ionosphere.GiroClient, Propagation.RunTiming, Accounts.Scope, RepoListener. Fixes were (a) prefix side-effect calls (Task.start, Phoenix.PubSub, Logger, :ets.new) with _ = ; (b) tighten/widen specs that didn't match actual returns; (c) add missing @type t declarations; (d) drop dead parse_int(nil) clause. - Propagation + weather subdirs (15): FreshnessMonitor, NotifyListener, ScoreCache, ScoreCacheReconciler, Weather.FrontalAnalysis, Weather.Grib2.Extractor, Weather.Grib2.Wgrib2, GridCache, HrrrPointEnqueuer, NexradCache. Same patterns — mostly _ = on PubSub / :ets / Repo.insert_all; widened two specs (float -> number) where integer returns were reachable. - Workers (35): BackfillEnqueue, CanadianSoundingFetch, ContactImport, ContactWeatherEnqueue, GefsFetch, IemreFetch, NarrFetch, SolarIndex, TerrainProfile, WeatherFetch. Prefixed Repo.update_all / Radio.set_enrichment_status! / Weather.upsert_* side-effect calls. Fixed one :pattern_match in CanadianSoundingFetch.most_recent_sounding_time/1 where a tautological cond guard generated unreachable code. - Web + Mix tasks + lib_ml (46 of 50): controllers, LiveViews, UserAuth, and 11 mix tasks. Same prefix strategy. 4 remaining warnings originate in LiveTable.LiveResource dep macro expansion and can't be fixed without forking the dep — added .dialyzer_ignore.exs to suppress just those specific file:line pairs. Also wired ignore_warnings in mix.exs dialyzer config. mix dialyzer --format short | grep ^lib/ | wc -l -> 0 mix test: 2163 tests, 3 pre-existing flakes, 0 regressions.
41 lines
1.3 KiB
Elixir
41 lines
1.3 KiB
Elixir
defmodule Microwaveprop.Propagation.RunTiming do
|
|
@moduledoc """
|
|
One row per forecast hour of a `PropagationGridWorker` chain, recording
|
|
how long that hour's fetch + score + persist cycle took.
|
|
|
|
Rows are keyed by `(run_time, forecast_hour)`. `run_time` is the HRRR
|
|
model cycle and `forecast_hour` ∈ 0..18.
|
|
"""
|
|
use Ecto.Schema
|
|
|
|
import Ecto.Changeset
|
|
|
|
@type t :: %__MODULE__{}
|
|
|
|
@primary_key {:id, :binary_id, autogenerate: true}
|
|
@foreign_key_type :binary_id
|
|
schema "propagation_run_timings" do
|
|
field :run_time, :utc_datetime
|
|
field :forecast_hour, :integer
|
|
field :valid_time, :utc_datetime
|
|
field :started_at, :utc_datetime_usec
|
|
field :finished_at, :utc_datetime_usec
|
|
field :duration_ms, :integer
|
|
field :status, Ecto.Enum, values: [:ok, :failed]
|
|
field :error, :string
|
|
|
|
timestamps(type: :utc_datetime, updated_at: false)
|
|
end
|
|
|
|
@required ~w(run_time forecast_hour valid_time started_at finished_at duration_ms status)a
|
|
@optional ~w(error)a
|
|
|
|
def changeset(row, attrs) do
|
|
row
|
|
|> cast(attrs, @required ++ @optional)
|
|
|> validate_required(@required)
|
|
|> validate_number(:forecast_hour, greater_than_or_equal_to: 0, less_than_or_equal_to: 18)
|
|
|> validate_number(:duration_ms, greater_than_or_equal_to: 0)
|
|
|> unique_constraint([:run_time, :forecast_hour])
|
|
end
|
|
end
|