Graham McIntire
cb8445f329
- Add 17 missing @spec annotations (layouts, error_json, error_html, skewt_svg) - Move 12+ nested alias/import/require to module top level - Add phx-change/id attributes to 11 raw HTML <form> tags - Remove 4 unused LiveView assigns (:bounds, :data_provider) - Add 3 missing doctest references (HrrrNativeClient, BulkFetch, Accounts) - Break 2 long lines (path_compute.ex:382) - Strengthen weak test assertions (is_binary→byte_size, is_list→!=[]) - Replace Module.concat with Module.safe_concat (2 occurrences) - Replace length/1 > 0 with list != [] (9 occurrences) - Remove no-op assert true, fix no-assertion tests Remaining: 24 socket.assigns introspection warnings (deliberate test pattern for observable behavior testing), 1 formatter-resistant long line, 3 app-code usage warnings.
65 lines
2.3 KiB
Elixir
65 lines
2.3 KiB
Elixir
defmodule MicrowavepropWeb.BeaconMonitorControllerTest do
|
|
use MicrowavepropWeb.ConnCase, async: true
|
|
|
|
import Microwaveprop.AccountsFixtures
|
|
|
|
alias Microwaveprop.BeaconMonitors
|
|
|
|
setup :register_and_log_in_user
|
|
|
|
describe "POST /users/beacon-monitors" do
|
|
test "creates a monitor for the current user", %{conn: conn, user: user} do
|
|
conn =
|
|
post(conn, ~p"/users/beacon-monitors", %{
|
|
"beacon_monitor" => %{"name" => "Shack Pi"}
|
|
})
|
|
|
|
assert redirected_to(conn) == ~p"/users/settings"
|
|
assert Phoenix.Flash.get(conn.assigns.flash, :info) =~ "Shack Pi"
|
|
|
|
assert [monitor] = BeaconMonitors.list_monitors_for_user(user)
|
|
assert monitor.name == "Shack Pi"
|
|
assert byte_size(monitor.token) > 0
|
|
end
|
|
|
|
test "shows an error when name is blank", %{conn: conn, user: user} do
|
|
conn =
|
|
post(conn, ~p"/users/beacon-monitors", %{
|
|
"beacon_monitor" => %{"name" => ""}
|
|
})
|
|
|
|
assert redirected_to(conn) == ~p"/users/settings"
|
|
assert Phoenix.Flash.get(conn.assigns.flash, :error) =~ "name"
|
|
assert BeaconMonitors.list_monitors_for_user(user) == []
|
|
end
|
|
|
|
test "redirects unauthenticated users to login" do
|
|
conn = post(build_conn(), ~p"/users/beacon-monitors", %{"beacon_monitor" => %{"name" => "Nope"}})
|
|
|
|
assert redirected_to(conn) == ~p"/users/log-in"
|
|
end
|
|
end
|
|
|
|
describe "DELETE /users/beacon-monitors/:id" do
|
|
test "deletes a monitor owned by the current user", %{conn: conn, user: user} do
|
|
{:ok, monitor} = BeaconMonitors.create_monitor(user, %{"name" => "Bye"})
|
|
|
|
conn = delete(conn, ~p"/users/beacon-monitors/#{monitor.id}")
|
|
|
|
assert redirected_to(conn) == ~p"/users/settings"
|
|
assert Phoenix.Flash.get(conn.assigns.flash, :info) =~ "deleted"
|
|
assert BeaconMonitors.list_monitors_for_user(user) == []
|
|
end
|
|
|
|
test "does not delete a monitor owned by another user", %{conn: conn} do
|
|
other = user_fixture()
|
|
{:ok, monitor} = BeaconMonitors.create_monitor(other, %{"name" => "Theirs"})
|
|
|
|
conn = delete(conn, ~p"/users/beacon-monitors/#{monitor.id}")
|
|
|
|
assert redirected_to(conn) == ~p"/users/settings"
|
|
assert Phoenix.Flash.get(conn.assigns.flash, :error) =~ "not found"
|
|
assert [_] = BeaconMonitors.list_monitors_for_user(other)
|
|
end
|
|
end
|
|
end
|