P0 (security-critical): - Gate CSV/ADIF upload tabs behind authentication, add 30s cooldown to all upload handlers - Cap CSV/ADIF imports at 2,000 rows server-side in both parsers - Add submitter_verified boolean to contacts (client-cannot-set, anonymous=false) - Create k8s/secret.example.yaml with placeholders, add LIVE_VIEW_SIGNING_SALT P1 (high-priority): - Add Mox.verify_on_exit!() to valkey_test.exs - Replace DateTime.utc_now() truncation with static ~U literals in map_live_test.exs - Replace Process.sleep with render_async in pskr_spots_live_test.exs (6 occurrences) - Add MonitorLive.Show test coverage (4 tests: owner view, non-owner redirect, config success/error) - Extract duct-detection and mechanism-classification logic from ContactLive.Show into Propagation.PathAnalysis - Split ContactLive.Show render into 12 function components - Update CLAUDE.md: remove stale ML model, mark HRDPS active, add backtest/pskr dirs - Batch CSV import enrichment jobs via new enqueue_for_contacts/1 P2 (medium-priority): - Set secure:true on session and remember-me cookies in production - Change SMTP TLS from verify_none to verify_peer with public_key cacerts - Make /metrics fail-closed in production when PROMETHEUS_AUTH_TOKEN unset - Add RateLimiter (anon_limit:10, auth_limit:60) to /api/contacts/map - Add content-security-policy-report-only header - Add comment noting String.to_atom is compile-time safe in hrdps_client.ex - Delegate duplicated haversine_km to canonical Microwaveprop.Geo.haversine_km/4 - Consolidate score-tier/color/verdict formatting into Microwaveprop.Format - Update CLAUDE.md testing section to match actual raw-string-matching practice - Batch HrrrPointEnqueuer Repo.insert_all calls to single round-trip - Split weather.ex (1696→216 lines) and radio.ex (1285→54 lines) into purpose-based sub-facades P3 (low-priority): - Add LIVE_VIEW_SIGNING_SALT warning comment, extend filter_parameters - Add host/community validation to snmp_client.ex - Add raw/1 safety comment in algo_live.ex - Add hex-audit and cargo-audit Makefile targets - Add privacy_live smoke test - Replace notify_listener busy-poll loop with Process.monitor/1 + assert_receive - Add ContactCommonVolumeRadar changeset validation tests (5 tests)
269 lines
8.6 KiB
Elixir
269 lines
8.6 KiB
Elixir
defmodule MicrowavepropWeb.UserAuth do
|
|
@moduledoc false
|
|
use MicrowavepropWeb, :verified_routes
|
|
|
|
import Phoenix.Controller
|
|
import Plug.Conn
|
|
|
|
alias Microwaveprop.Accounts
|
|
alias Microwaveprop.Accounts.Scope
|
|
alias Phoenix.LiveView.Socket
|
|
|
|
# Make the remember me cookie valid for 14 days. This should match
|
|
# the session validity setting in UserToken.
|
|
@max_cookie_age_in_days 14
|
|
@remember_me_cookie "_microwaveprop_web_user_remember_me"
|
|
@remember_me_options [
|
|
sign: true,
|
|
max_age: @max_cookie_age_in_days * 24 * 60 * 60,
|
|
same_site: "Lax",
|
|
secure: Mix.env() == :prod
|
|
]
|
|
|
|
@doc """
|
|
LiveView `on_mount` callback that assigns `:current_scope` from the
|
|
session token so LiveView templates can show auth-aware navigation.
|
|
|
|
The `:require_admin` variant halts and redirects users who are not
|
|
logged in or not flagged as admin. Use it via `live_session`.
|
|
"""
|
|
@spec on_mount(:default | :require_admin, any(), map(), Socket.t()) ::
|
|
{:cont, Socket.t()} | {:halt, Socket.t()}
|
|
def on_mount(:default, _params, session, socket) do
|
|
{:cont, mount_current_scope(socket, session)}
|
|
end
|
|
|
|
def on_mount(:require_admin, _params, session, socket) do
|
|
socket = mount_current_scope(socket, session)
|
|
user = socket.assigns.current_scope && socket.assigns.current_scope.user
|
|
|
|
if user && user.is_admin do
|
|
{:cont, socket}
|
|
else
|
|
socket =
|
|
socket
|
|
|> Phoenix.LiveView.put_flash(:error, "You must be an admin to access that page.")
|
|
|> Phoenix.LiveView.redirect(to: ~p"/")
|
|
|
|
{:halt, socket}
|
|
end
|
|
end
|
|
|
|
defp mount_current_scope(socket, session) do
|
|
Phoenix.Component.assign_new(socket, :current_scope, fn ->
|
|
user =
|
|
with token when is_binary(token) <- session["user_token"],
|
|
{user, _inserted_at} <- Accounts.get_user_by_session_token(token) do
|
|
user
|
|
else
|
|
_ -> nil
|
|
end
|
|
|
|
Scope.for_user(user)
|
|
end)
|
|
end
|
|
|
|
# How old the session token should be before a new one is issued. When a request is made
|
|
# with a session token older than this value, then a new session token will be created
|
|
# and the session and remember-me cookies (if set) will be updated with the new token.
|
|
# Lowering this value will result in more tokens being created by active users. Increasing
|
|
# it will result in less time before a session token expires for a user to get issued a new
|
|
# token. This can be set to a value greater than `@max_cookie_age_in_days` to disable
|
|
# the reissuing of tokens completely.
|
|
@session_reissue_age_in_days 7
|
|
|
|
@doc """
|
|
Logs the user in.
|
|
|
|
Redirects to the session's `:user_return_to` path
|
|
or falls back to the `signed_in_path/1`.
|
|
"""
|
|
@spec log_in_user(Plug.Conn.t(), Microwaveprop.Accounts.User.t(), map()) :: Plug.Conn.t()
|
|
def log_in_user(conn, user, params \\ %{}) do
|
|
user_return_to = get_session(conn, :user_return_to)
|
|
|
|
conn
|
|
|> create_or_extend_session(user, params)
|
|
|> redirect(to: user_return_to || signed_in_path(conn))
|
|
end
|
|
|
|
@doc """
|
|
Logs the user out.
|
|
|
|
It clears all session data for safety. See renew_session.
|
|
"""
|
|
@spec log_out_user(Plug.Conn.t()) :: Plug.Conn.t()
|
|
def log_out_user(conn) do
|
|
user_token = get_session(conn, :user_token)
|
|
user_token && Accounts.delete_user_session_token(user_token)
|
|
|
|
_ =
|
|
if live_socket_id = get_session(conn, :live_socket_id) do
|
|
MicrowavepropWeb.Endpoint.broadcast(live_socket_id, "disconnect", %{})
|
|
end
|
|
|
|
conn
|
|
|> renew_session(nil)
|
|
|> delete_resp_cookie(@remember_me_cookie, @remember_me_options)
|
|
|> redirect(to: ~p"/")
|
|
end
|
|
|
|
@doc """
|
|
Authenticates the user by looking into the session and remember me token.
|
|
|
|
Will reissue the session token if it is older than the configured age.
|
|
"""
|
|
@spec fetch_current_scope_for_user(Plug.Conn.t(), any()) :: Plug.Conn.t()
|
|
def fetch_current_scope_for_user(conn, _opts) do
|
|
with {token, conn} <- ensure_user_token(conn),
|
|
{user, token_inserted_at} <- Accounts.get_user_by_session_token(token) do
|
|
conn
|
|
|> assign(:current_scope, Scope.for_user(user))
|
|
|> maybe_reissue_user_session_token(user, token_inserted_at)
|
|
else
|
|
nil -> assign(conn, :current_scope, Scope.for_user(nil))
|
|
end
|
|
end
|
|
|
|
defp ensure_user_token(conn) do
|
|
if token = get_session(conn, :user_token) do
|
|
{token, conn}
|
|
else
|
|
conn = fetch_cookies(conn, signed: [@remember_me_cookie])
|
|
|
|
if token = conn.cookies[@remember_me_cookie] do
|
|
{token, conn |> put_token_in_session(token) |> put_session(:user_remember_me, true)}
|
|
end
|
|
end
|
|
end
|
|
|
|
# Reissue the session token if it is older than the configured reissue age.
|
|
defp maybe_reissue_user_session_token(conn, user, token_inserted_at) do
|
|
token_age = DateTime.diff(DateTime.utc_now(:second), token_inserted_at, :day)
|
|
|
|
if token_age >= @session_reissue_age_in_days do
|
|
create_or_extend_session(conn, user, %{})
|
|
else
|
|
conn
|
|
end
|
|
end
|
|
|
|
# This function is the one responsible for creating session tokens
|
|
# and storing them safely in the session and cookies. It may be called
|
|
# either when logging in, during sudo mode, or to renew a session which
|
|
# will soon expire.
|
|
#
|
|
# When the session is created, rather than extended, the renew_session
|
|
# function will clear the session to avoid fixation attacks. See the
|
|
# renew_session function to customize this behaviour.
|
|
defp create_or_extend_session(conn, user, params) do
|
|
token = Accounts.generate_user_session_token(user)
|
|
remember_me = get_session(conn, :user_remember_me)
|
|
|
|
conn
|
|
|> renew_session(user)
|
|
|> put_token_in_session(token)
|
|
|> maybe_write_remember_me_cookie(token, params, remember_me)
|
|
end
|
|
|
|
# Do not renew session if the user is already logged in
|
|
# to prevent CSRF errors or data being lost in tabs that are still open
|
|
defp renew_session(conn, %{id: user_id}) when conn.assigns.current_scope.user.id == user_id do
|
|
conn
|
|
end
|
|
|
|
# This function renews the session ID and erases the whole
|
|
# session to avoid fixation attacks. If there is any data
|
|
# in the session you may want to preserve after log in/log out,
|
|
# you must explicitly fetch the session data before clearing
|
|
# and then immediately set it after clearing, for example:
|
|
#
|
|
# defp renew_session(conn, _user) do
|
|
# delete_csrf_token()
|
|
# preferred_locale = get_session(conn, :preferred_locale)
|
|
#
|
|
# conn
|
|
# |> configure_session(renew: true)
|
|
# |> clear_session()
|
|
# |> put_session(:preferred_locale, preferred_locale)
|
|
# end
|
|
#
|
|
defp renew_session(conn, _user) do
|
|
delete_csrf_token()
|
|
|
|
conn
|
|
|> configure_session(renew: true)
|
|
|> clear_session()
|
|
end
|
|
|
|
defp maybe_write_remember_me_cookie(conn, token, %{"remember_me" => "true"}, _),
|
|
do: write_remember_me_cookie(conn, token)
|
|
|
|
defp maybe_write_remember_me_cookie(conn, token, _params, true), do: write_remember_me_cookie(conn, token)
|
|
|
|
defp maybe_write_remember_me_cookie(conn, _token, _params, _), do: conn
|
|
|
|
defp write_remember_me_cookie(conn, token) do
|
|
conn
|
|
|> put_session(:user_remember_me, true)
|
|
|> put_resp_cookie(@remember_me_cookie, token, @remember_me_options)
|
|
end
|
|
|
|
defp put_token_in_session(conn, token) do
|
|
put_session(conn, :user_token, token)
|
|
end
|
|
|
|
@doc """
|
|
Plug for routes that require sudo mode.
|
|
"""
|
|
@spec require_sudo_mode(Plug.Conn.t(), any()) :: Plug.Conn.t()
|
|
def require_sudo_mode(conn, _opts) do
|
|
if Accounts.sudo_mode?(conn.assigns.current_scope.user, -60 * 24) do
|
|
conn
|
|
else
|
|
conn
|
|
|> put_flash(:error, "You must re-authenticate to access this page.")
|
|
|> maybe_store_return_to()
|
|
|> redirect(to: ~p"/users/log-in")
|
|
|> halt()
|
|
end
|
|
end
|
|
|
|
@doc """
|
|
Plug for routes that require the user to not be authenticated.
|
|
"""
|
|
@spec redirect_if_user_is_authenticated(Plug.Conn.t(), any()) :: Plug.Conn.t()
|
|
def redirect_if_user_is_authenticated(conn, _opts) do
|
|
if conn.assigns.current_scope do
|
|
conn
|
|
|> redirect(to: signed_in_path(conn))
|
|
|> halt()
|
|
else
|
|
conn
|
|
end
|
|
end
|
|
|
|
defp signed_in_path(_conn), do: ~p"/"
|
|
|
|
@doc """
|
|
Plug for routes that require the user to be authenticated.
|
|
"""
|
|
@spec require_authenticated_user(Plug.Conn.t(), any()) :: Plug.Conn.t()
|
|
def require_authenticated_user(conn, _opts) do
|
|
if conn.assigns.current_scope && conn.assigns.current_scope.user do
|
|
conn
|
|
else
|
|
conn
|
|
|> put_flash(:error, "You must log in to access this page.")
|
|
|> maybe_store_return_to()
|
|
|> redirect(to: ~p"/users/log-in")
|
|
|> halt()
|
|
end
|
|
end
|
|
|
|
defp maybe_store_return_to(%{method: "GET"} = conn) do
|
|
put_session(conn, :user_return_to, current_path(conn))
|
|
end
|
|
|
|
defp maybe_store_return_to(conn), do: conn
|
|
end
|