prop/lib/microwaveprop_web/endpoint.ex
Graham McIntire 0c3be97abb
Some checks failed
Build base image / Build and push base image (push) Successful in 3m10s
Build and Push / Build and Push Docker Image (push) Failing after 14s
Build prop-grid-rs / Test, build, push (push) Successful in 12m52s
fix: resolve 27 security, architecture, test, and performance audit findings
P0 (security-critical):
- Gate CSV/ADIF upload tabs behind authentication, add 30s cooldown to all upload handlers
- Cap CSV/ADIF imports at 2,000 rows server-side in both parsers
- Add submitter_verified boolean to contacts (client-cannot-set, anonymous=false)
- Create k8s/secret.example.yaml with placeholders, add LIVE_VIEW_SIGNING_SALT

P1 (high-priority):
- Add Mox.verify_on_exit!() to valkey_test.exs
- Replace DateTime.utc_now() truncation with static ~U literals in map_live_test.exs
- Replace Process.sleep with render_async in pskr_spots_live_test.exs (6 occurrences)
- Add MonitorLive.Show test coverage (4 tests: owner view, non-owner redirect, config success/error)
- Extract duct-detection and mechanism-classification logic from ContactLive.Show into Propagation.PathAnalysis
- Split ContactLive.Show render into 12 function components
- Update CLAUDE.md: remove stale ML model, mark HRDPS active, add backtest/pskr dirs
- Batch CSV import enrichment jobs via new enqueue_for_contacts/1

P2 (medium-priority):
- Set secure:true on session and remember-me cookies in production
- Change SMTP TLS from verify_none to verify_peer with public_key cacerts
- Make /metrics fail-closed in production when PROMETHEUS_AUTH_TOKEN unset
- Add RateLimiter (anon_limit:10, auth_limit:60) to /api/contacts/map
- Add content-security-policy-report-only header
- Add comment noting String.to_atom is compile-time safe in hrdps_client.ex
- Delegate duplicated haversine_km to canonical Microwaveprop.Geo.haversine_km/4
- Consolidate score-tier/color/verdict formatting into Microwaveprop.Format
- Update CLAUDE.md testing section to match actual raw-string-matching practice
- Batch HrrrPointEnqueuer Repo.insert_all calls to single round-trip
- Split weather.ex (1696→216 lines) and radio.ex (1285→54 lines) into purpose-based sub-facades

P3 (low-priority):
- Add LIVE_VIEW_SIGNING_SALT warning comment, extend filter_parameters
- Add host/community validation to snmp_client.ex
- Add raw/1 safety comment in algo_live.ex
- Add hex-audit and cargo-audit Makefile targets
- Add privacy_live smoke test
- Replace notify_listener busy-poll loop with Process.monitor/1 + assert_receive
- Add ContactCommonVolumeRadar changeset validation tests (5 tests)
2026-07-27 18:19:37 -05:00

89 lines
3.3 KiB
Elixir

defmodule MicrowavepropWeb.Endpoint do
use Phoenix.Endpoint, otp_app: :microwaveprop
# The session will be stored in the cookie and signed,
# this means its contents can be read but not tampered with.
# Set :encryption_salt if you would also like to encrypt it.
@session_options [
store: :cookie,
key: "_microwaveprop_key",
signing_salt: "FBet7+Mi",
encryption_salt: "fPEhSH1PIkX0MJMU1WL3",
same_site: "Lax",
secure: Mix.env() == :prod
]
socket "/live", Phoenix.LiveView.Socket,
websocket: [connect_info: [session: @session_options]],
longpoll: [connect_info: [session: @session_options]]
# Serve at "/" the static files from "priv/static" directory.
#
# When code reloading is disabled (e.g., in production),
# the `gzip` option is enabled to serve compressed
# static files generated by running `phx.digest`.
plug Plug.Static,
at: "/",
from: :microwaveprop,
gzip: not code_reloading?,
only: MicrowavepropWeb.static_paths(),
raise_on_missing_only: code_reloading?
if code_reloading? do
plug Tidewave
end
# Code reloading can be explicitly enabled under the
# :code_reloader configuration of your endpoint.
if code_reloading? do
socket "/phoenix/live_reload/socket", Phoenix.LiveReloader.Socket
plug Phoenix.LiveReloader
plug Phoenix.CodeReloader
plug Phoenix.Ecto.CheckRepoStatus, otp_app: :microwaveprop
end
plug Phoenix.LiveDashboard.RequestLogger,
param_key: "request_logger",
cookie_key: "request_logger"
plug Plug.RequestId
plug MicrowavepropWeb.Plugs.RemoteIp
# Plug.Head (below) rewrites method=HEAD to "GET" before
# Plug.Telemetry's register_before_send callback fires, so a
# `log_level(%{method: "HEAD"})` clause never matches. Capture
# the original method in private here so the log filter can still
# see HEAD requests and suppress them.
plug :stash_request_method
plug Plug.Telemetry, event_prefix: [:phoenix, :endpoint], log: {__MODULE__, :log_level, []}
plug Plug.Parsers,
parsers: [:urlencoded, :multipart, :json],
pass: ["*/*"],
json_decoder: Phoenix.json_library()
plug Plug.MethodOverride
plug Plug.Head
plug Plug.Session, @session_options
plug MicrowavepropWeb.Router
@doc false
# Match on `request_path` rather than `path_info` because `Plug.forward/4`
# (used by `forward "/metrics", MetricsPlug` in the router) rewrites
# `path_info` to the unmatched remainder before dispatching to the
# forwarded plug. `MetricsPlug` calls `send_resp/2` inside that
# dispatch, so `Plug.Telemetry`'s `register_before_send` callback sees
# `path_info: []` / `script_name: ["metrics"]` and a clause keyed on
# `path_info` never matches. `request_path` is set once by the adapter
# and is stable across forward, so it's the reliable discriminator.
@spec log_level(Plug.Conn.t()) :: false | :info
def log_level(%{request_path: "/health"}), do: false
def log_level(%{request_path: "/live"}), do: false
def log_level(%{request_path: "/metrics"}), do: false
def log_level(%{request_path: "/metrics/" <> _}), do: false
def log_level(%{private: %{original_method: "HEAD"}}), do: false
def log_level(_conn), do: :info
defp stash_request_method(conn, _opts) do
Plug.Conn.put_private(conn, :original_method, conn.method)
end
end