prop/lib/microwaveprop_web/controllers/contact_map_controller.ex
Graham McIntire 0c3be97abb
Some checks failed
Build base image / Build and push base image (push) Successful in 3m10s
Build and Push / Build and Push Docker Image (push) Failing after 14s
Build prop-grid-rs / Test, build, push (push) Successful in 12m52s
fix: resolve 27 security, architecture, test, and performance audit findings
P0 (security-critical):
- Gate CSV/ADIF upload tabs behind authentication, add 30s cooldown to all upload handlers
- Cap CSV/ADIF imports at 2,000 rows server-side in both parsers
- Add submitter_verified boolean to contacts (client-cannot-set, anonymous=false)
- Create k8s/secret.example.yaml with placeholders, add LIVE_VIEW_SIGNING_SALT

P1 (high-priority):
- Add Mox.verify_on_exit!() to valkey_test.exs
- Replace DateTime.utc_now() truncation with static ~U literals in map_live_test.exs
- Replace Process.sleep with render_async in pskr_spots_live_test.exs (6 occurrences)
- Add MonitorLive.Show test coverage (4 tests: owner view, non-owner redirect, config success/error)
- Extract duct-detection and mechanism-classification logic from ContactLive.Show into Propagation.PathAnalysis
- Split ContactLive.Show render into 12 function components
- Update CLAUDE.md: remove stale ML model, mark HRDPS active, add backtest/pskr dirs
- Batch CSV import enrichment jobs via new enqueue_for_contacts/1

P2 (medium-priority):
- Set secure:true on session and remember-me cookies in production
- Change SMTP TLS from verify_none to verify_peer with public_key cacerts
- Make /metrics fail-closed in production when PROMETHEUS_AUTH_TOKEN unset
- Add RateLimiter (anon_limit:10, auth_limit:60) to /api/contacts/map
- Add content-security-policy-report-only header
- Add comment noting String.to_atom is compile-time safe in hrdps_client.ex
- Delegate duplicated haversine_km to canonical Microwaveprop.Geo.haversine_km/4
- Consolidate score-tier/color/verdict formatting into Microwaveprop.Format
- Update CLAUDE.md testing section to match actual raw-string-matching practice
- Batch HrrrPointEnqueuer Repo.insert_all calls to single round-trip
- Split weather.ex (1696→216 lines) and radio.ex (1285→54 lines) into purpose-based sub-facades

P3 (low-priority):
- Add LIVE_VIEW_SIGNING_SALT warning comment, extend filter_parameters
- Add host/community validation to snmp_client.ex
- Add raw/1 safety comment in algo_live.ex
- Add hex-audit and cargo-audit Makefile targets
- Add privacy_live smoke test
- Replace notify_listener busy-poll loop with Process.monitor/1 + assert_receive
- Add ContactCommonVolumeRadar changeset validation tests (5 tests)
2026-07-27 18:19:37 -05:00

60 lines
1.8 KiB
Elixir

defmodule MicrowavepropWeb.ContactMapController do
@moduledoc """
Serves the contact map JSON payload as a standalone HTTP endpoint. Keeps
the ~5 MB blob out of the `/contacts/map` LiveView's initial HTML response
and lets the browser's native `Content-Encoding: gzip` handling do the
compression. The payload itself is served from `Microwaveprop.Cache` via
`Radio.contact_map_payload/0`.
"""
use MicrowavepropWeb, :controller
alias Microwaveprop.Cache
alias Microwaveprop.Radio
alias MicrowavepropWeb.Api.RateLimiter
plug RateLimiter, anon_limit: 10, auth_limit: 60
@cache_key {__MODULE__, :gzipped_payload}
@cache_ttl_ms 10 * 60 * 1_000
@doc false
@spec cache_key() :: {module(), :gzipped_payload}
def cache_key, do: @cache_key
@spec show(Plug.Conn.t(), map()) :: Plug.Conn.t()
def show(conn, _params) do
{body, encoding} = gzipped_or_plain_body(conn)
conn
|> put_resp_content_type("application/json")
|> maybe_put_encoding(encoding)
|> put_resp_header("cache-control", "public, max-age=60")
|> send_resp(200, body)
end
defp gzipped_or_plain_body(conn) do
if accepts_gzip?(conn) do
{gzipped_payload(), :gzip}
else
%{json: iodata} = Radio.contact_map_payload()
{IO.iodata_to_binary(iodata), :identity}
end
end
defp gzipped_payload do
Cache.fetch_or_store(@cache_key, @cache_ttl_ms, fn ->
%{json: iodata} = Radio.contact_map_payload()
:zlib.gzip(IO.iodata_to_binary(iodata))
end)
end
defp accepts_gzip?(conn) do
case get_req_header(conn, "accept-encoding") do
[value | _] -> String.contains?(value, "gzip")
_ -> false
end
end
defp maybe_put_encoding(conn, :gzip), do: put_resp_header(conn, "content-encoding", "gzip")
defp maybe_put_encoding(conn, :identity), do: conn
end