Graham McIntire
0c3be97abb
P0 (security-critical): - Gate CSV/ADIF upload tabs behind authentication, add 30s cooldown to all upload handlers - Cap CSV/ADIF imports at 2,000 rows server-side in both parsers - Add submitter_verified boolean to contacts (client-cannot-set, anonymous=false) - Create k8s/secret.example.yaml with placeholders, add LIVE_VIEW_SIGNING_SALT P1 (high-priority): - Add Mox.verify_on_exit!() to valkey_test.exs - Replace DateTime.utc_now() truncation with static ~U literals in map_live_test.exs - Replace Process.sleep with render_async in pskr_spots_live_test.exs (6 occurrences) - Add MonitorLive.Show test coverage (4 tests: owner view, non-owner redirect, config success/error) - Extract duct-detection and mechanism-classification logic from ContactLive.Show into Propagation.PathAnalysis - Split ContactLive.Show render into 12 function components - Update CLAUDE.md: remove stale ML model, mark HRDPS active, add backtest/pskr dirs - Batch CSV import enrichment jobs via new enqueue_for_contacts/1 P2 (medium-priority): - Set secure:true on session and remember-me cookies in production - Change SMTP TLS from verify_none to verify_peer with public_key cacerts - Make /metrics fail-closed in production when PROMETHEUS_AUTH_TOKEN unset - Add RateLimiter (anon_limit:10, auth_limit:60) to /api/contacts/map - Add content-security-policy-report-only header - Add comment noting String.to_atom is compile-time safe in hrdps_client.ex - Delegate duplicated haversine_km to canonical Microwaveprop.Geo.haversine_km/4 - Consolidate score-tier/color/verdict formatting into Microwaveprop.Format - Update CLAUDE.md testing section to match actual raw-string-matching practice - Batch HrrrPointEnqueuer Repo.insert_all calls to single round-trip - Split weather.ex (1696→216 lines) and radio.ex (1285→54 lines) into purpose-based sub-facades P3 (low-priority): - Add LIVE_VIEW_SIGNING_SALT warning comment, extend filter_parameters - Add host/community validation to snmp_client.ex - Add raw/1 safety comment in algo_live.ex - Add hex-audit and cargo-audit Makefile targets - Add privacy_live smoke test - Replace notify_listener busy-poll loop with Process.monitor/1 + assert_receive - Add ContactCommonVolumeRadar changeset validation tests (5 tests)
68 lines
2.4 KiB
Elixir
68 lines
2.4 KiB
Elixir
defmodule Microwaveprop.Radio.ContactCommonVolumeRadarTest do
|
|
use Microwaveprop.DataCase, async: true
|
|
|
|
alias Ecto.Changeset
|
|
alias Microwaveprop.Radio.ContactCommonVolumeRadar
|
|
|
|
@contact_id "00000000-0000-0000-0000-000000000001"
|
|
|
|
@valid_attrs %{
|
|
contact_id: "00000000-0000-0000-0000-000000000001",
|
|
observed_at: ~U[2026-03-28 12:00:00Z]
|
|
}
|
|
|
|
@all_attrs Map.merge(@valid_attrs, %{
|
|
common_volume_km2: 150_000.5,
|
|
pixel_count: 10_000,
|
|
rain_pixel_count: 500,
|
|
heavy_rain_pixel_count: 50,
|
|
core_pixel_count: 5,
|
|
max_dbz: 65.5,
|
|
mean_dbz: 12.3,
|
|
coverage_pct: 85.2
|
|
})
|
|
|
|
describe "changeset/2" do
|
|
test "valid with minimum required fields" do
|
|
changeset = ContactCommonVolumeRadar.changeset(%ContactCommonVolumeRadar{}, @valid_attrs)
|
|
assert changeset.valid?
|
|
end
|
|
|
|
test "rejects missing contact_id" do
|
|
changeset =
|
|
ContactCommonVolumeRadar.changeset(%ContactCommonVolumeRadar{}, %{
|
|
observed_at: ~U[2026-03-28 12:00:00Z]
|
|
})
|
|
|
|
assert %{contact_id: ["can't be blank"]} = errors_on(changeset)
|
|
end
|
|
|
|
test "rejects missing observed_at" do
|
|
changeset =
|
|
ContactCommonVolumeRadar.changeset(%ContactCommonVolumeRadar{}, %{
|
|
contact_id: @contact_id
|
|
})
|
|
|
|
assert %{observed_at: ["can't be blank"]} = errors_on(changeset)
|
|
end
|
|
|
|
test "accepts all optional fields" do
|
|
changeset = ContactCommonVolumeRadar.changeset(%ContactCommonVolumeRadar{}, @all_attrs)
|
|
assert changeset.valid?
|
|
|
|
assert Changeset.get_field(changeset, :common_volume_km2) == 150_000.5
|
|
assert Changeset.get_field(changeset, :pixel_count) == 10_000
|
|
assert Changeset.get_field(changeset, :rain_pixel_count) == 500
|
|
assert Changeset.get_field(changeset, :heavy_rain_pixel_count) == 50
|
|
assert Changeset.get_field(changeset, :core_pixel_count) == 5
|
|
assert Changeset.get_field(changeset, :max_dbz) == 65.5
|
|
assert Changeset.get_field(changeset, :mean_dbz) == 12.3
|
|
assert Changeset.get_field(changeset, :coverage_pct) == 85.2
|
|
end
|
|
|
|
test "has unique_constraint on contact_id" do
|
|
changeset = ContactCommonVolumeRadar.changeset(%ContactCommonVolumeRadar{}, @valid_attrs)
|
|
assert Enum.any?(changeset.constraints, &(&1.type == :unique))
|
|
end
|
|
end
|
|
end
|