prop/lib/microwaveprop/rover/drive_time.ex
Graham McIntire 0c3be97abb
Some checks failed
Build base image / Build and push base image (push) Successful in 3m10s
Build and Push / Build and Push Docker Image (push) Failing after 14s
Build prop-grid-rs / Test, build, push (push) Successful in 12m52s
fix: resolve 27 security, architecture, test, and performance audit findings
P0 (security-critical):
- Gate CSV/ADIF upload tabs behind authentication, add 30s cooldown to all upload handlers
- Cap CSV/ADIF imports at 2,000 rows server-side in both parsers
- Add submitter_verified boolean to contacts (client-cannot-set, anonymous=false)
- Create k8s/secret.example.yaml with placeholders, add LIVE_VIEW_SIGNING_SALT

P1 (high-priority):
- Add Mox.verify_on_exit!() to valkey_test.exs
- Replace DateTime.utc_now() truncation with static ~U literals in map_live_test.exs
- Replace Process.sleep with render_async in pskr_spots_live_test.exs (6 occurrences)
- Add MonitorLive.Show test coverage (4 tests: owner view, non-owner redirect, config success/error)
- Extract duct-detection and mechanism-classification logic from ContactLive.Show into Propagation.PathAnalysis
- Split ContactLive.Show render into 12 function components
- Update CLAUDE.md: remove stale ML model, mark HRDPS active, add backtest/pskr dirs
- Batch CSV import enrichment jobs via new enqueue_for_contacts/1

P2 (medium-priority):
- Set secure:true on session and remember-me cookies in production
- Change SMTP TLS from verify_none to verify_peer with public_key cacerts
- Make /metrics fail-closed in production when PROMETHEUS_AUTH_TOKEN unset
- Add RateLimiter (anon_limit:10, auth_limit:60) to /api/contacts/map
- Add content-security-policy-report-only header
- Add comment noting String.to_atom is compile-time safe in hrdps_client.ex
- Delegate duplicated haversine_km to canonical Microwaveprop.Geo.haversine_km/4
- Consolidate score-tier/color/verdict formatting into Microwaveprop.Format
- Update CLAUDE.md testing section to match actual raw-string-matching practice
- Batch HrrrPointEnqueuer Repo.insert_all calls to single round-trip
- Split weather.ex (1696→216 lines) and radio.ex (1285→54 lines) into purpose-based sub-facades

P3 (low-priority):
- Add LIVE_VIEW_SIGNING_SALT warning comment, extend filter_parameters
- Add host/community validation to snmp_client.ex
- Add raw/1 safety comment in algo_live.ex
- Add hex-audit and cargo-audit Makefile targets
- Add privacy_live smoke test
- Replace notify_listener busy-poll loop with Process.monitor/1 + assert_receive
- Add ContactCommonVolumeRadar changeset validation tests (5 tests)
2026-07-27 18:19:37 -05:00

46 lines
1.5 KiB
Elixir

defmodule Microwaveprop.Rover.DriveTime do
@moduledoc """
Distance, drive-time, and compass-bearing helpers for the rover
planner. All inputs are degrees / kilometres; no I/O.
"""
@avg_speed_kmh 65.0
@spec haversine_km({float(), float()}, {float(), float()}) :: float()
def haversine_km({lat1, lon1}, {lat2, lon2}) do
Microwaveprop.Geo.haversine_km(lat1, lon1, lat2, lon2)
end
@spec drive_min(float()) :: float()
def drive_min(dist_km) when is_number(dist_km), do: dist_km / @avg_speed_kmh * 60.0
@spec bearing_compass({float(), float()}, {float(), float()}) :: String.t()
def bearing_compass(from, to) do
from |> bearing_deg(to) |> compass_for()
end
@spec bearing_deg({float(), float()}, {float(), float()}) :: float()
def bearing_deg({lat1, lon1}, {lat2, lon2}) do
rlat1 = deg_to_rad(lat1)
rlat2 = deg_to_rad(lat2)
dlon = deg_to_rad(lon2 - lon1)
y = :math.sin(dlon) * :math.cos(rlat2)
x = :math.cos(rlat1) * :math.sin(rlat2) - :math.sin(rlat1) * :math.cos(rlat2) * :math.cos(dlon)
y |> :math.atan2(x) |> rad_to_deg() |> normalize_deg()
end
@compass_points {"N", "NE", "E", "SE", "S", "SW", "W", "NW"}
defp compass_for(bearing) do
index = bearing |> Kernel.+(22.5) |> div_floor(45.0) |> rem(8)
elem(@compass_points, index)
end
defp div_floor(a, b), do: trunc(a / b)
defp deg_to_rad(deg), do: deg * :math.pi() / 180.0
defp rad_to_deg(rad), do: rad * 180.0 / :math.pi()
defp normalize_deg(deg), do: deg |> Kernel.+(360.0) |> :math.fmod(360.0)
end