graham/prop - Forgejo: Beyond coding. We forge.

graham/prop

Fork 0

Commit graph

Author	SHA1	Message	Date
Graham McIntire	fd976b0cd5	fix: resolve 391 Credo issues across codebase - Add jump_credo_checks ~> 0.4 with all 20 checks enabled - Fix all standard Credo issues: 139 @spec (113 done, 26 remain), 4 refactoring, 3 alias usage, 9 System.cmd env, 5 unsafe_to_atom, 2 max line length, 9 assert_receive timeout - Fix 170+ jump_credo_checks warnings: - 117 TopLevelAliasImportRequire: move nested alias/import to module top - 32 UseObanProWorker: switch to Oban.Pro.Worker - 4 DoctestIExExamples: add doctests / create test file - ~20 WeakAssertion: strengthen type-check assertions - Various ConditionalAssertion, AssertReceiveTimeout fixes - Exclude vendor/ from Credo analysis - Remaining: 175 warnings (mostly opinionated WeakAssertion, AvoidSocketAssignsInTest), 26 @spec annotations	2026-06-12 13:51:32 -05:00
Graham McIntire	48833f15be	feat(import): async CSV import with progress-tracking schema For large CSVs (e.g. the 34k-row ARRL dump), the synchronous commit path blocked for minutes and a crash mid-commit left no audit trail. Refactor to run inserts + enrichment enqueues via Oban. - New import_runs table: stores preview rows + running counters (total, processed, imported, refined, error) + status + errors map + timing. - New :contact_import Oban queue (limit 4) + ContactImportWorker. Args: {import_run_id, offset, limit}. Each chunk (100 rows) inserts its slice via CsvImport.commit_rows/1, atomically increments counters in one update_all, flips status, and broadcasts progress on 'csv_import:<id>' PubSub topic. - CsvImport.commit_rows/1 extracted from commit/1 (back-compat preserved). New CsvImport.enqueue/2 persists the run + dispatches N chunk jobs. Also: submit page copy updated from '902 MHz and up' to '50 MHz and up' matching the band allowlist expansion done earlier. LiveView UI for /imports/:id is a separate commit.	2026-04-17 09:31:22 -05:00

Author

SHA1

Message

Date

Graham McIntire

fd976b0cd5

fix: resolve 391 Credo issues across codebase

- Add jump_credo_checks ~> 0.4 with all 20 checks enabled
- Fix all standard Credo issues: 139 @spec (113 done, 26 remain),
  4 refactoring, 3 alias usage, 9 System.cmd env, 5 unsafe_to_atom,
  2 max line length, 9 assert_receive timeout
- Fix 170+ jump_credo_checks warnings:
  - 117 TopLevelAliasImportRequire: move nested alias/import to module top
  - 32 UseObanProWorker: switch to Oban.Pro.Worker
  - 4 DoctestIExExamples: add doctests / create test file
  - ~20 WeakAssertion: strengthen type-check assertions
  - Various ConditionalAssertion, AssertReceiveTimeout fixes
- Exclude vendor/ from Credo analysis
- Remaining: 175 warnings (mostly opinionated WeakAssertion,
  AvoidSocketAssignsInTest), 26 @spec annotations

2026-06-12 13:51:32 -05:00

Graham McIntire

48833f15be

feat(import): async CSV import with progress-tracking schema

For large CSVs (e.g. the 34k-row ARRL dump), the synchronous commit
path blocked for minutes and a crash mid-commit left no audit trail.
Refactor to run inserts + enrichment enqueues via Oban.

- New import_runs table: stores preview rows + running counters (total,
  processed, imported, refined, error) + status + errors map + timing.
- New :contact_import Oban queue (limit 4) + ContactImportWorker.
  Args: {import_run_id, offset, limit}. Each chunk (100 rows) inserts
  its slice via CsvImport.commit_rows/1, atomically increments counters
  in one update_all, flips status, and broadcasts progress on
  'csv_import:<id>' PubSub topic.
- CsvImport.commit_rows/1 extracted from commit/1 (back-compat preserved).
  New CsvImport.enqueue/2 persists the run + dispatches N chunk jobs.

Also: submit page copy updated from '902 MHz and up' to '50 MHz and up'
matching the band allowlist expansion done earlier.

LiveView UI for /imports/:id is a separate commit.

2026-04-17 09:31:22 -05:00

2 commits