|
|
d61fbd346e
|
fix(dialyzer): clear 125+ warnings under strict flags
Enabled :error_handling, :unknown, :unmatched_returns, :extra_return,
:missing_return in an earlier commit and landed a 129-warning baseline.
Four parallel agents each fixed a directory slice:
- Core contexts (29): Radio, Release, Weather, Beacons, Cache,
Backtest.Features, Terrain.Srtm, Ionosphere.GiroClient,
Propagation.RunTiming, Accounts.Scope, RepoListener. Fixes were
(a) prefix side-effect calls (Task.start, Phoenix.PubSub,
Logger, :ets.new) with _ = ; (b) tighten/widen specs that didn't
match actual returns; (c) add missing @type t declarations;
(d) drop dead parse_int(nil) clause.
- Propagation + weather subdirs (15): FreshnessMonitor, NotifyListener,
ScoreCache, ScoreCacheReconciler, Weather.FrontalAnalysis,
Weather.Grib2.Extractor, Weather.Grib2.Wgrib2, GridCache,
HrrrPointEnqueuer, NexradCache. Same patterns — mostly _ = on
PubSub / :ets / Repo.insert_all; widened two specs (float ->
number) where integer returns were reachable.
- Workers (35): BackfillEnqueue, CanadianSoundingFetch,
ContactImport, ContactWeatherEnqueue, GefsFetch, IemreFetch,
NarrFetch, SolarIndex, TerrainProfile, WeatherFetch. Prefixed
Repo.update_all / Radio.set_enrichment_status! / Weather.upsert_*
side-effect calls. Fixed one :pattern_match in
CanadianSoundingFetch.most_recent_sounding_time/1 where a
tautological cond guard generated unreachable code.
- Web + Mix tasks + lib_ml (46 of 50): controllers, LiveViews,
UserAuth, and 11 mix tasks. Same prefix strategy. 4 remaining
warnings originate in LiveTable.LiveResource dep macro expansion
and can't be fixed without forking the dep — added .dialyzer_ignore.exs
to suppress just those specific file:line pairs.
Also wired ignore_warnings in mix.exs dialyzer config.
mix dialyzer --format short | grep ^lib/ | wc -l -> 0
mix test: 2163 tests, 3 pre-existing flakes, 0 regressions.
|
2026-04-21 10:30:06 -05:00 |
|
|
|
33f5d4edbe
|
feat(rainscatter): classify QSO propagation mechanism from common-volume radar
Adds a per-contact enrichment pipeline that determines whether a QSO was
most likely carried by rain scatter, tropospheric ducting, or ordinary
troposcatter — using IEM n0q composite reflectivity sampled inside the
lens-shaped intersection of 400 km-radius disks around each endpoint.
Pieces:
* Microwaveprop.Propagation.CommonVolume — lens geometry (haversine,
in-CV test, bbox, area).
* contact_common_volume_radar table (1:1 per contact) storing
aggregate dBZ stats inside the CV + radar_status column on contacts.
* Microwaveprop.Workers.CommonVolumeRadarWorker — Oban :radar queue,
fetches the n0q frame at QSO time, iterates pixels inside the CV
bbox, aggregates rain/heavy/core-pixel counts, max/mean dBZ, and
coverage percentage.
* Microwaveprop.Propagation.RainScatterClassifier — rule-based mapper
from (band, distance, radar stats, duct flags) to one of
:likely_rainscatter | :rainscatter_possible | :tropo_duct |
:troposcatter | :unknown.
* ContactWeatherEnqueueWorker learns a :radar enrichment type and
enqueues the CV worker on contact submission; pre-2014 contacts
(outside IEM n0q coverage) are pinned to :unavailable.
* `mix radar_backfill` bulk-enqueues historical contacts with
--year / --limit / --dry-run.
* Contact detail page renders a mechanism badge with supporting
stats (common-volume area, max dBZ, heavy-rain pixel count,
coverage %).
|
2026-04-17 15:57:59 -05:00 |
|
