d61fbd346e
fix(dialyzer): clear 125+ warnings under strict flags
...
Enabled :error_handling, :unknown, :unmatched_returns, :extra_return,
:missing_return in an earlier commit and landed a 129-warning baseline.
Four parallel agents each fixed a directory slice:
- Core contexts (29): Radio, Release, Weather, Beacons, Cache,
Backtest.Features, Terrain.Srtm, Ionosphere.GiroClient,
Propagation.RunTiming, Accounts.Scope, RepoListener. Fixes were
(a) prefix side-effect calls (Task.start, Phoenix.PubSub,
Logger, :ets.new) with _ = ; (b) tighten/widen specs that didn't
match actual returns; (c) add missing @type t declarations;
(d) drop dead parse_int(nil) clause.
- Propagation + weather subdirs (15): FreshnessMonitor, NotifyListener,
ScoreCache, ScoreCacheReconciler, Weather.FrontalAnalysis,
Weather.Grib2.Extractor, Weather.Grib2.Wgrib2, GridCache,
HrrrPointEnqueuer, NexradCache. Same patterns — mostly _ = on
PubSub / :ets / Repo.insert_all; widened two specs (float ->
number) where integer returns were reachable.
- Workers (35): BackfillEnqueue, CanadianSoundingFetch,
ContactImport, ContactWeatherEnqueue, GefsFetch, IemreFetch,
NarrFetch, SolarIndex, TerrainProfile, WeatherFetch. Prefixed
Repo.update_all / Radio.set_enrichment_status! / Weather.upsert_*
side-effect calls. Fixed one :pattern_match in
CanadianSoundingFetch.most_recent_sounding_time/1 where a
tautological cond guard generated unreachable code.
- Web + Mix tasks + lib_ml (46 of 50): controllers, LiveViews,
UserAuth, and 11 mix tasks. Same prefix strategy. 4 remaining
warnings originate in LiveTable.LiveResource dep macro expansion
and can't be fixed without forking the dep — added .dialyzer_ignore.exs
to suppress just those specific file:line pairs.
Also wired ignore_warnings in mix.exs dialyzer config.
mix dialyzer --format short | grep ^lib/ | wc -l -> 0
mix test: 2163 tests, 3 pre-existing flakes, 0 regressions.
2026-04-21 10:30:06 -05:00
7fb340bc35
Fix all remaining credo --strict issues (0 issues)
...
Aliases: add module aliases for 9 nested module references
Apply: replace apply/3 with direct module attribute calls
Line length: break 1 long spec line
Refactoring: extract helpers to reduce complexity and nesting
in show.ex, radio.ex, weather workers, terrain, duct detection,
backfill dashboard, contact map, and mix tasks
2026-04-12 10:26:53 -05:00
e7a7ae073d
Phase 9.3, 9.4, and Phase 3 NEXRAD pipeline
...
Task 9.3 - Weight recalibration via gradient descent:
- Recalibrator module fits logistic regression weights using Nx
- Trains on QSO positives vs random baseline negatives
- Cross-validates by month, normalizes weights to sum to 1.0
- Mix task: mix recalibrate_scorer --sample 5000 --epochs 2000
Task 9.4 - Side-by-side scorer comparison:
- ScorerDiff.compare/3 re-scores grid with old vs new weights
- Reports mean diff, regressions, improvements, per-band breakdown
- Mix task: mix scorer_diff --new-weights '{...}'
Phase 3 - NEXRAD ingestion pipeline:
- NexradClient fetches IEM n0q composite PNGs, extracts per-point
box statistics (mean/max dBZ, texture variance)
- NexradObservation schema with unique (lat, lon, observed_at)
- NexradWorker on :nexrad queue for background processing
- nexrad_texture backtest feature in Features module
- mix nexrad_backfill --limit 200
All tasks added to AdminTaskWorker and Release for production use.
1116 tests, 0 failures.
2026-04-10 12:48:36 -05:00
