d61fbd346e
fix(dialyzer): clear 125+ warnings under strict flags
...
Enabled :error_handling, :unknown, :unmatched_returns, :extra_return,
:missing_return in an earlier commit and landed a 129-warning baseline.
Four parallel agents each fixed a directory slice:
- Core contexts (29): Radio, Release, Weather, Beacons, Cache,
Backtest.Features, Terrain.Srtm, Ionosphere.GiroClient,
Propagation.RunTiming, Accounts.Scope, RepoListener. Fixes were
(a) prefix side-effect calls (Task.start, Phoenix.PubSub,
Logger, :ets.new) with _ = ; (b) tighten/widen specs that didn't
match actual returns; (c) add missing @type t declarations;
(d) drop dead parse_int(nil) clause.
- Propagation + weather subdirs (15): FreshnessMonitor, NotifyListener,
ScoreCache, ScoreCacheReconciler, Weather.FrontalAnalysis,
Weather.Grib2.Extractor, Weather.Grib2.Wgrib2, GridCache,
HrrrPointEnqueuer, NexradCache. Same patterns — mostly _ = on
PubSub / :ets / Repo.insert_all; widened two specs (float ->
number) where integer returns were reachable.
- Workers (35): BackfillEnqueue, CanadianSoundingFetch,
ContactImport, ContactWeatherEnqueue, GefsFetch, IemreFetch,
NarrFetch, SolarIndex, TerrainProfile, WeatherFetch. Prefixed
Repo.update_all / Radio.set_enrichment_status! / Weather.upsert_*
side-effect calls. Fixed one :pattern_match in
CanadianSoundingFetch.most_recent_sounding_time/1 where a
tautological cond guard generated unreachable code.
- Web + Mix tasks + lib_ml (46 of 50): controllers, LiveViews,
UserAuth, and 11 mix tasks. Same prefix strategy. 4 remaining
warnings originate in LiveTable.LiveResource dep macro expansion
and can't be fixed without forking the dep — added .dialyzer_ignore.exs
to suppress just those specific file:line pairs.
Also wired ignore_warnings in mix.exs dialyzer config.
mix dialyzer --format short | grep ^lib/ | wc -l -> 0
mix test: 2163 tests, 3 pre-existing flakes, 0 regressions.
2026-04-21 10:30:06 -05:00
1d86e287b2
Add password auth with callsign + email confirmation
...
Generated Accounts context, User schema, and controllers via
phx.gen.auth. Adapted it for password-only login with required
email confirmation:
- Users have callsign (unique, uppercased), name, email, password
- Registration form fields: callsign, name, email, password, confirm
- Magic-link login path removed; login is email + password only
- After register, a confirmation email is sent and login is blocked
until the account is confirmed via the token URL
- Confirmation link logs the user in on first use
- SMTP2GO configured as the outgoing mailer in k8s prod
2026-04-08 10:21:40 -05:00
