d61fbd346e
fix(dialyzer): clear 125+ warnings under strict flags
...
Enabled :error_handling, :unknown, :unmatched_returns, :extra_return,
:missing_return in an earlier commit and landed a 129-warning baseline.
Four parallel agents each fixed a directory slice:
- Core contexts (29): Radio, Release, Weather, Beacons, Cache,
Backtest.Features, Terrain.Srtm, Ionosphere.GiroClient,
Propagation.RunTiming, Accounts.Scope, RepoListener. Fixes were
(a) prefix side-effect calls (Task.start, Phoenix.PubSub,
Logger, :ets.new) with _ = ; (b) tighten/widen specs that didn't
match actual returns; (c) add missing @type t declarations;
(d) drop dead parse_int(nil) clause.
- Propagation + weather subdirs (15): FreshnessMonitor, NotifyListener,
ScoreCache, ScoreCacheReconciler, Weather.FrontalAnalysis,
Weather.Grib2.Extractor, Weather.Grib2.Wgrib2, GridCache,
HrrrPointEnqueuer, NexradCache. Same patterns — mostly _ = on
PubSub / :ets / Repo.insert_all; widened two specs (float ->
number) where integer returns were reachable.
- Workers (35): BackfillEnqueue, CanadianSoundingFetch,
ContactImport, ContactWeatherEnqueue, GefsFetch, IemreFetch,
NarrFetch, SolarIndex, TerrainProfile, WeatherFetch. Prefixed
Repo.update_all / Radio.set_enrichment_status! / Weather.upsert_*
side-effect calls. Fixed one :pattern_match in
CanadianSoundingFetch.most_recent_sounding_time/1 where a
tautological cond guard generated unreachable code.
- Web + Mix tasks + lib_ml (46 of 50): controllers, LiveViews,
UserAuth, and 11 mix tasks. Same prefix strategy. 4 remaining
warnings originate in LiveTable.LiveResource dep macro expansion
and can't be fixed without forking the dep — added .dialyzer_ignore.exs
to suppress just those specific file:line pairs.
Also wired ignore_warnings in mix.exs dialyzer config.
mix dialyzer --format short | grep ^lib/ | wc -l -> 0
mix test: 2163 tests, 3 pre-existing flakes, 0 regressions.
2026-04-21 10:30:06 -05:00
3604896726
Rename ERA5 → NARR across the codebase
...
- Schema: Era5Profile → NarrProfile; table renamed via migration
rename_era5_profiles_to_narr_profiles (ALTER TABLE + rename indexes,
atomic and instant, no row rewrite)
- Weather helpers: find_nearest_era5/era5_for_contact/era5_profiles_for_path
→ find_nearest_narr/narr_for_contact/narr_profiles_for_path
- BackfillEnqueueWorker: :era5 → :narr type (virtual, no narr_status column);
reconcile_stale_queued_to_unavailable and status_priority_order now skip
virtual types via @virtual_types. Fixes the prod crash where the cron tried
to update a non-existent era5_status column.
- ContactWeatherEnqueueWorker: build_era5_jobs → build_narr_jobs,
era5_jobs_for_contact → narr_jobs_for_contact
- ContactLive: @era5 → @narr, maybe_enqueue_era5 → maybe_enqueue_narr;
UI label "ERA5 (0.25°)" → "NARR (32 km)"
- Cron (runtime.exs): args types list now "narr" instead of "era5"
- /status: progress row, status-by-type card, totals.narr_profiles, and
table-count lookup all target narr_profiles
- Drop obsolete Era5CdsJob schema + era5_cds_jobs table (inspection
artifact from the retired CDS pipeline; 34 orphan rows in prod)
- Misc docstring/comment cleanups (skew_t, about, wgrib2, propagation_train)
Includes a regression test for the virtual-type crash.
2026-04-16 09:22:23 -05:00
7c33af7278
Add Microwaveprop.Workers.NarrFetchWorker
...
Per-contact Oban worker that fetches one NARR profile via
NarrClient.fetch_profile_at/2 and inserts it into era5_profiles.
Replaces Era5FetchWorker for pre-2014 contacts. Unlike the ERA5
router, NARR fetches are per-point so this worker does the fetch
+ insert directly — no downstream batch worker, no routing.
Args shape matches Era5FetchWorker: %{"lat", "lon", "valid_time"}.
Lat/lon get snapped to 0.25° (same dedup granularity as ERA5).
valid_time MUST already be on a 3-hourly NARR analysis slot
(00/03/06/09/12/15/18/21 UTC on the hour) — the worker raises
ArgumentError via NarrClient.url_for/1 otherwise. Caller-side
snapping (in ContactWeatherEnqueueWorker) lands in the next task.
Existence check tightened to ±15 minutes (vs ERA5's ±30) since NARR
is exact 3-hourly. On error, logs a warning and returns {:error,
reason} so Oban retries with backoff (max_attempts: 3).
The :narr Oban queue config and the ContactWeatherEnqueueWorker
swap are deliberately NOT touched in this commit — those are the
next two tasks of the plan.
2026-04-15 18:54:02 -05:00
