graham/prop - Forgejo: Beyond coding. We forge.

graham/prop

Fork 0

Commit graph

Author	SHA1	Message	Date
Graham McIntire	9db2cd20f5	fix: resolve 7 pre-existing test failures and ScoreCache DateTime bug - CacheTest: fix sweep timing race by using negative TTL (-1) instead of positive TTL (1) for already-expired entries - ScoreCache: replace ETS match-spec DateTime comparisons with :ets.foldl + DateTime.compare — DateTime structs are maps in Elixir >= 1.15 and ETS can't compare maps with :< / :> guards - Accounts: drop unsupported returning: true on delete_all, return [] for expired tokens list - Backtest: catch ArgumentError from String.to_existing_atom for unknown feature names, preserving the helpful Mix.Error - ContactLive IndexTest: invalidate monthly_bars cache before assertion so test data is visible - RoverLocationsLive MapTest: invalidate cached points before assertion - StatusLiveTest: add DB cleanup in setup to reduce test interference; parameterize NARR candidate coordinates	2026-06-10 13:50:24 -05:00
Graham McIntire	cc3dc41a6b	Fix all medium findings and split contact_live_test.exs - Fix N+1 queries in radio.ex (preload :user) - Add encryption_salt to session options - Consolidate token deletion to single query - Wrap gunzip in try/rescue for corrupt files - Add Cache.match_delete/1 to encapsulate ETS access - Precompute sec_i_factor_ref as module attribute - Guard EXLA.Backend config to dev/test only - Split 3505-line contact_live_test.exs into 4 files - Replace Process.sleep with :sys.get_state synchronization - Replace Process.alive? with DOM output assertions - Clarify router.ex comment for non-live_session routes - Update findings.md to reflect fixes	2026-05-29 15:53:04 -05:00
Graham McIntire	f99d07bd29	test: push line coverage from 71.7% → 78.67% Adds ~600 new test cases (2013 → 2613 tests; 170 properties; 0 failures) across 12 new test files plus expansions of eight existing files. Big lifts per module: ContactLive.Mechanism 33 → 100% MetricsPlug 54 → ~100% Microwaveprop.Release 15.8 → 70%+ Telemetry 38 → 76% HrrrNativeGridWorker 27.7 → 76% ContactLive.Show 34 → 48% (handler + render branches) Admin.ContactEditLive 49.7 → 70%+ GefsFetchWorker 35.8 → ~55% IonosphereFetchWorker 56.3 → 75% PathLive 58.9 → 67% WeatherMapLive 66.9 → 80.2% RoverLive 0 → 70.3% ContactMapLive 59.2 → 89.8% ContactMapController 0 → 100% Mix tasks (Rust.Golden, Notebook, Backtest, HrrrBackfill, HrrrClimatology, HrrrNativeBackfill, NexradBackfill, RadarBackfill, ImportContestLogs, PropagationGrid, ResetEnrichment, Hrrr.PurgeGridPoints) 0 → ~60-100% Two incidental fixes made while adding tests: - ContactLive.Show.handle_event("toggle_flag", ...) was passing socket.assigns.current_scope to admin?/1 instead of socket.assigns, so admins never matched the pattern and every toggle ran the "Admins only." flash branch. Flag now toggles for admins again. - Commercial.PollWorker.fetch_weather/1 promoted from private to @doc'd public so the IEM-fetch + ASOS-upsert path can be tested directly without driving perform/1 through live SNMP (which was timing out for ~50 s per test in the earlier attempt). Stable property-test additions cover the dewpoint-from-RH monotonicity, nearest_run/1 idempotence, and the ionosphere station envelope.	2026-04-23 18:43:18 -05:00

Author

SHA1

Message

Date

Graham McIntire

9db2cd20f5

fix: resolve 7 pre-existing test failures and ScoreCache DateTime bug

- CacheTest: fix sweep timing race by using negative TTL (-1)
  instead of positive TTL (1) for already-expired entries
- ScoreCache: replace ETS match-spec DateTime comparisons with
  :ets.foldl + DateTime.compare — DateTime structs are maps in
  Elixir >= 1.15 and ETS can't compare maps with :< / :> guards
- Accounts: drop unsupported returning: true on delete_all,
  return [] for expired tokens list
- Backtest: catch ArgumentError from String.to_existing_atom
  for unknown feature names, preserving the helpful Mix.Error
- ContactLive IndexTest: invalidate monthly_bars cache before
  assertion so test data is visible
- RoverLocationsLive MapTest: invalidate cached points before
  assertion
- StatusLiveTest: add DB cleanup in setup to reduce test
  interference; parameterize NARR candidate coordinates

2026-06-10 13:50:24 -05:00

Graham McIntire

cc3dc41a6b

Fix all medium findings and split contact_live_test.exs

- Fix N+1 queries in radio.ex (preload :user)
- Add encryption_salt to session options
- Consolidate token deletion to single query
- Wrap gunzip in try/rescue for corrupt files
- Add Cache.match_delete/1 to encapsulate ETS access
- Precompute sec_i_factor_ref as module attribute
- Guard EXLA.Backend config to dev/test only
- Split 3505-line contact_live_test.exs into 4 files
- Replace Process.sleep with :sys.get_state synchronization
- Replace Process.alive? with DOM output assertions
- Clarify router.ex comment for non-live_session routes
- Update findings.md to reflect fixes

2026-05-29 15:53:04 -05:00

Graham McIntire

f99d07bd29

test: push line coverage from 71.7% → 78.67%

Adds ~600 new test cases (2013 → 2613 tests; 170 properties; 0
failures) across 12 new test files plus expansions of eight existing
files. Big lifts per module:

  ContactLive.Mechanism      33 → 100%
  MetricsPlug                54 → ~100%
  Microwaveprop.Release      15.8 → 70%+
  Telemetry                  38 → 76%
  HrrrNativeGridWorker       27.7 → 76%
  ContactLive.Show           34 → 48% (handler + render branches)
  Admin.ContactEditLive      49.7 → 70%+
  GefsFetchWorker            35.8 → ~55%
  IonosphereFetchWorker      56.3 → 75%
  PathLive                   58.9 → 67%
  WeatherMapLive             66.9 → 80.2%
  RoverLive                  0 → 70.3%
  ContactMapLive             59.2 → 89.8%
  ContactMapController       0 → 100%
  Mix tasks (Rust.Golden, Notebook, Backtest, HrrrBackfill,
    HrrrClimatology, HrrrNativeBackfill, NexradBackfill,
    RadarBackfill, ImportContestLogs, PropagationGrid,
    ResetEnrichment, Hrrr.PurgeGridPoints)  0 → ~60-100%

Two incidental fixes made while adding tests:

- ContactLive.Show.handle_event("toggle_flag", ...) was passing
  socket.assigns.current_scope to admin?/1 instead of socket.assigns,
  so admins never matched the pattern and every toggle ran the
  "Admins only." flash branch. Flag now toggles for admins again.

- Commercial.PollWorker.fetch_weather/1 promoted from private to
  @doc'd public so the IEM-fetch + ASOS-upsert path can be tested
  directly without driving perform/1 through live SNMP (which was
  timing out for ~50 s per test in the earlier attempt).

Stable property-test additions cover the dewpoint-from-RH monotonicity,
nearest_run/1 idempotence, and the ionosphere station envelope.

2026-04-23 18:43:18 -05:00

3 commits