fd976b0cd5
fix: resolve 391 Credo issues across codebase
...
- Add jump_credo_checks ~> 0.4 with all 20 checks enabled
- Fix all standard Credo issues: 139 @spec (113 done, 26 remain),
4 refactoring, 3 alias usage, 9 System.cmd env, 5 unsafe_to_atom,
2 max line length, 9 assert_receive timeout
- Fix 170+ jump_credo_checks warnings:
- 117 TopLevelAliasImportRequire: move nested alias/import to module top
- 32 UseObanProWorker: switch to Oban.Pro.Worker
- 4 DoctestIExExamples: add doctests / create test file
- ~20 WeakAssertion: strengthen type-check assertions
- Various ConditionalAssertion, AssertReceiveTimeout fixes
- Exclude vendor/ from Credo analysis
- Remaining: 175 warnings (mostly opinionated WeakAssertion,
AvoidSocketAssignsInTest), 26 @spec annotations
2026-06-12 13:51:32 -05:00
d61fbd346e
fix(dialyzer): clear 125+ warnings under strict flags
...
Enabled :error_handling, :unknown, :unmatched_returns, :extra_return,
:missing_return in an earlier commit and landed a 129-warning baseline.
Four parallel agents each fixed a directory slice:
- Core contexts (29): Radio, Release, Weather, Beacons, Cache,
Backtest.Features, Terrain.Srtm, Ionosphere.GiroClient,
Propagation.RunTiming, Accounts.Scope, RepoListener. Fixes were
(a) prefix side-effect calls (Task.start, Phoenix.PubSub,
Logger, :ets.new) with _ = ; (b) tighten/widen specs that didn't
match actual returns; (c) add missing @type t declarations;
(d) drop dead parse_int(nil) clause.
- Propagation + weather subdirs (15): FreshnessMonitor, NotifyListener,
ScoreCache, ScoreCacheReconciler, Weather.FrontalAnalysis,
Weather.Grib2.Extractor, Weather.Grib2.Wgrib2, GridCache,
HrrrPointEnqueuer, NexradCache. Same patterns — mostly _ = on
PubSub / :ets / Repo.insert_all; widened two specs (float ->
number) where integer returns were reachable.
- Workers (35): BackfillEnqueue, CanadianSoundingFetch,
ContactImport, ContactWeatherEnqueue, GefsFetch, IemreFetch,
NarrFetch, SolarIndex, TerrainProfile, WeatherFetch. Prefixed
Repo.update_all / Radio.set_enrichment_status! / Weather.upsert_*
side-effect calls. Fixed one :pattern_match in
CanadianSoundingFetch.most_recent_sounding_time/1 where a
tautological cond guard generated unreachable code.
- Web + Mix tasks + lib_ml (46 of 50): controllers, LiveViews,
UserAuth, and 11 mix tasks. Same prefix strategy. 4 remaining
warnings originate in LiveTable.LiveResource dep macro expansion
and can't be fixed without forking the dep — added .dialyzer_ignore.exs
to suppress just those specific file:line pairs.
Also wired ignore_warnings in mix.exs dialyzer config.
mix dialyzer --format short | grep ^lib/ | wc -l -> 0
mix test: 2163 tests, 3 pre-existing flakes, 0 regressions.
2026-04-21 10:30:06 -05:00
