<%= for tier <- @estimate.tiers do %>
assign(:beacon, beacon)
|> assign(:show_coverage, false)
|> assign(:coverage_supported, coverage_supported?(beacon))
- |> assign(:estimate, RangeEstimate.estimate(beacon))}
+ # Estimate is lazy — computed on the first toggle-on to avoid
+ # paying the bbox grid cost on every page load.
+ |> assign(:estimate, nil)}
end
# Estimated current coverage only makes sense from 5.76 GHz upward,
@@ -180,15 +182,32 @@ defmodule MicrowavepropWeb.BeaconLive.Show do
@impl true
def handle_event("toggle_coverage", _params, socket) do
- if socket.assigns.coverage_supported do
- show = not socket.assigns.show_coverage
+ cond do
+ not socket.assigns.coverage_supported ->
+ {:noreply, socket}
- {:noreply,
- socket
- |> assign(:show_coverage, show)
- |> push_event("toggle_coverage", %{show: show})}
- else
- {:noreply, socket}
+ socket.assigns.show_coverage ->
+ # Already on, user is turning it off.
+ {:noreply,
+ socket
+ |> assign(:show_coverage, false)
+ |> push_event("toggle_coverage", %{show: false})}
+
+ true ->
+ # First time turning on (or re-enabling after off) — compute
+ # the estimate if we don't already have it, then push the
+ # cell payload to the hook.
+ estimate = socket.assigns.estimate || RangeEstimate.estimate(socket.assigns.beacon)
+
+ {:noreply,
+ socket
+ |> assign(:show_coverage, true)
+ |> assign(:estimate, estimate)
+ |> push_event("load_coverage", %{
+ grid_step: estimate.grid_step,
+ cells: estimate.cells,
+ show: true
+ })}
end
end
@@ -208,13 +227,35 @@ defmodule MicrowavepropWeb.BeaconLive.Show do
@impl true
def handle_info({:updated, %Beacon{id: id} = beacon}, %{assigns: %{beacon: %{id: id}}} = socket) do
supported = coverage_supported?(beacon)
+ show? = socket.assigns.show_coverage and supported
- {:noreply,
- socket
- |> assign(:beacon, beacon)
- |> assign(:coverage_supported, supported)
- |> assign(:show_coverage, socket.assigns.show_coverage and supported)
- |> assign(:estimate, RangeEstimate.estimate(beacon))}
+ # Only recompute the estimate if coverage was already displayed —
+ # otherwise leave it nil and let the next toggle lazy-load it.
+ estimate =
+ if show? and socket.assigns.estimate do
+ RangeEstimate.estimate(beacon)
+ else
+ socket.assigns.estimate
+ end
+
+ socket =
+ socket
+ |> assign(:beacon, beacon)
+ |> assign(:coverage_supported, supported)
+ |> assign(:show_coverage, show?)
+ |> assign(:estimate, estimate)
+
+ # Re-push fresh cells to the hook if the map is currently visible.
+ if show? and estimate do
+ {:noreply,
+ push_event(socket, "load_coverage", %{
+ grid_step: estimate.grid_step,
+ cells: estimate.cells,
+ show: true
+ })}
+ else
+ {:noreply, socket}
+ end
end
def handle_info({:deleted, %Beacon{id: id}}, %{assigns: %{beacon: %{id: id}}} = socket) do
diff --git a/test/microwaveprop_web/live/beacon_live_test.exs b/test/microwaveprop_web/live/beacon_live_test.exs
index ba198d7d..5a011acb 100644
--- a/test/microwaveprop_web/live/beacon_live_test.exs
+++ b/test/microwaveprop_web/live/beacon_live_test.exs
@@ -168,4 +168,46 @@ defmodule MicrowavepropWeb.BeaconLiveTest do
assert {:error, {:redirect, %{to: "/"}}} = live(conn, ~p"/beacons/#{beacon}/edit")
end
end
+
+ describe "Show — lazy coverage" do
+ test "does not compute the estimate or embed cells on mount", %{conn: conn} do
+ beacon = approved_beacon_fixture(user_fixture(), frequency_mhz: 10_368.1)
+ {:ok, view, html} = live(conn, ~p"/beacons/#{beacon}")
+
+ # Map div exists but data-cells is absent or empty until the user
+ # flips the toggle — we don't want to pay the RangeEstimate cost
+ # on every page load.
+ refute html =~ "data-cells"
+ assert has_element?(view, "input[phx-click='toggle_coverage']")
+ end
+
+ test "flipping the toggle computes the estimate and pushes coverage data", %{conn: conn} do
+ beacon = approved_beacon_fixture(user_fixture(), frequency_mhz: 10_368.1)
+ {:ok, view, html} = live(conn, ~p"/beacons/#{beacon}")
+
+ # Before the click the coverage info bar is absent.
+ refute html =~ "cells rendered"
+
+ render_click(element(view, "input[phx-click='toggle_coverage']"))
+ html = render(view)
+
+ # After toggling on, the coverage info bar (which only renders
+ # when @estimate is populated and @show_coverage is true) shows.
+ assert html =~ "cells rendered"
+ assert html =~ "Atm loss"
+ end
+
+ test "toggle_coverage is a no-op for beacons below 5.76 GHz", %{conn: conn} do
+ beacon = approved_beacon_fixture(user_fixture(), frequency_mhz: 1296.0)
+ {:ok, view, html} = live(conn, ~p"/beacons/#{beacon}")
+
+ assert html =~ "5.76 GHz and up only"
+ refute html =~ "data-cells"
+ refute html =~ "cells rendered"
+
+ # Even if a client-side hack forces the click, the server refuses.
+ render_click(view, "toggle_coverage")
+ refute render(view) =~ "cells rendered"
+ end
+ end
end