diff --git a/lib/microwaveprop/pskr/client.ex b/lib/microwaveprop/pskr/client.ex index 9c8b0356..e06d00cf 100644 --- a/lib/microwaveprop/pskr/client.ex +++ b/lib/microwaveprop/pskr/client.ex @@ -178,22 +178,40 @@ defmodule Microwaveprop.Pskr.Client do # ---------- Connection setup ---------- defp do_connect(state) do + # Open in passive mode for the synchronous CONNECT/CONNACK + # handshake — `:gen_tcp.recv/3` only works on passive sockets + # and returns `:einval` if the socket is in any active mode. + # After CONNACK we flip to `active: :once` so PUBLISHes arrive + # as `{:tcp, socket, data}` messages. + # # `:inet` forces IPv4 resolution + an IPv4 socket. Without - # this, BEAM can pick the broker's AAAA record while our K8s - # pod has IPv4-only egress, and `:gen_tcp.connect/4` fails - # with `:einval` from the kernel `connect()` syscall. - tcp_opts = [:binary, :inet, active: :once, packet: :raw, keepalive: true] + # this, BEAM can pick a broker AAAA record while our K8s pod + # has IPv4-only egress. + tcp_opts = [:binary, :inet, active: false, packet: :raw, keepalive: true] - with {:ok, socket} <- :gen_tcp.connect(@broker_host, @broker_port, tcp_opts, 10_000), - :ok <- :gen_tcp.send(socket, Mqtt.connect(state.client_id, @keepalive_seconds)), + case :gen_tcp.connect(@broker_host, @broker_port, tcp_opts, 10_000) do + {:ok, socket} -> handshake(socket, state) + {:error, _} = err -> err + end + end + + defp handshake(socket, state) do + with :ok <- :gen_tcp.send(socket, Mqtt.connect(state.client_id, @keepalive_seconds)), {:ok, :connected, rest} <- await_connack(socket, <<>>), - :ok <- :gen_tcp.send(socket, subscribe_packet(state.bands)) do + :ok <- :gen_tcp.send(socket, subscribe_packet(state.bands)), + :ok <- :inet.setopts(socket, active: :once) do Logger.info("Pskr.Client connected as #{state.client_id}, subscribed to #{length(state.bands)} bands") # `rest` holds anything the broker sent piggybacked after # CONNACK — feed it back into the buffer so we don't lose # the SUBACK or an early PUBLISH. send(self(), {:tcp, socket, rest}) {:ok, socket, schedule_ping()} + else + {:error, _} = err -> + # Close the connected-but-not-handshaked socket so we + # don't leak ports across retries. + _ = :gen_tcp.close(socket) + err end end