perf+fix: parallelize path HRRR queries; fix meteor-shower year boundary

Audit pass found two real issues (most agent-flagged items were false
positives — the hrrr_native_profiles composite index exists,
pwat_mm/bl_depth_m are already in the path conditions map, and the
/1.0 in MechanismClassifier is the standard Elixir int→float coerce).

1. Path calculator's 9-point HRRR sampling was running sequentially,
   ~9× the latency of a single query. Task.async_stream with
   max_concurrency: 9 makes them concurrent so path calc pays roughly
   one query's worth of time instead of nine.

2. MechanismClassifyWorker's meteor-shower window used hardcoded 2024
   peak dates with `%{date | year: peak.year}` projection. That broke
   across year boundaries — a Dec 30 contact couldn't match a Jan 4
   Quadrantids peak even in-range of the ±3 day window. Switched to
   {month, day} tuples and check the peak projected onto year N-1, N,
   N+1 so the window works correctly near Dec 31 / Jan 1.
This commit is contained in:
Graham McIntire 2026-04-18 12:08:35 -05:00
parent 181ad19c24
commit 2874e6a93b
No known key found for this signature in database
GPG key ID: F4ABF488E6029E59
3 changed files with 66 additions and 16 deletions

View file

@ -190,26 +190,44 @@ defmodule Microwaveprop.Workers.MechanismClassifyWorker do
)
end
# Static meteor-shower calendar (peak dates, approximate). Any contact
# within ±3 days of a peak counts as "during the shower."
# Static meteor-shower calendar (peak month/day, approximate). Any
# contact within ±3 days of a peak counts as "during the shower."
# Peaks are stored as {month, day} so year substitution doesn't
# poison year-boundary showers (Jan Quadrantids vs Dec Ursids).
@showers [
{~D[2024-01-04], "Quadrantids"},
{~D[2024-04-22], "Lyrids"},
{~D[2024-05-06], "Eta Aquariids"},
{~D[2024-07-30], "Southern Delta Aquariids"},
{~D[2024-08-12], "Perseids"},
{~D[2024-10-21], "Orionids"},
{~D[2024-11-17], "Leonids"},
{~D[2024-12-14], "Geminids"},
{~D[2024-12-22], "Ursids"}
{{1, 4}, "Quadrantids"},
{{4, 22}, "Lyrids"},
{{5, 6}, "Eta Aquariids"},
{{7, 30}, "Southern Delta Aquariids"},
{{8, 12}, "Perseids"},
{{10, 21}, "Orionids"},
{{11, 17}, "Leonids"},
{{12, 14}, "Geminids"},
{{12, 22}, "Ursids"}
]
@shower_window_days 3
defp active_shower_at(%DateTime{} = ts) do
date = DateTime.to_date(ts)
Enum.find_value(@showers, fn {peak_mmdd, name} ->
diff = abs(Date.diff(peak_mmdd, %{date | year: peak_mmdd.year}))
if diff <= 3, do: name
Enum.find_value(@showers, fn {{month, day}, name} ->
if shower_active?(date, month, day), do: name
end)
end
# Returns true when `date` falls within `@shower_window_days` of the
# shower peak, handling year-boundary showers (e.g. Ursids peak Dec 22
# can match a QSO on Dec 25 in year N or, when the window widens,
# early January in year N+1). We check the peak projected onto the
# contact's year AND the adjacent years so the ±3-day window works
# correctly across Dec 31 → Jan 1.
defp shower_active?(%Date{year: year} = date, month, day) do
Enum.any?([year - 1, year, year + 1], fn y ->
case Date.new(y, month, day) do
{:ok, peak} -> abs(Date.diff(peak, date)) <= @shower_window_days
_ -> false
end
end)
end

View file

@ -257,8 +257,12 @@ defmodule MicrowavepropWeb.PathLive do
hrrr_points =
src
|> path_sample_points(dst, 9)
|> Enum.map(&label_hrrr_point(&1, now))
|> Enum.reject(&is_nil/1)
|> Task.async_stream(&label_hrrr_point(&1, now), max_concurrency: 9, timeout: 10_000, on_timeout: :kill_task)
|> Enum.flat_map(fn
{:ok, nil} -> []
{:ok, point} -> [point]
{:exit, _} -> []
end)
hrrr_profiles = Enum.map(hrrr_points, & &1.profile)

View file

@ -137,5 +137,33 @@ defmodule Microwaveprop.Workers.MechanismClassifyWorkerTest do
args: %{"contact_id" => fake_id}
})
end
test "meteor-shower calendar matches across year boundaries" do
# Quadrantids peak Jan 4, ±3 day window. A 6 m 900 km contact on
# Dec 31 2025 is 4 days before the Jan 4 2026 peak — should still
# pass through shower-active matching (though classification may
# be meteor_scatter only if other mechanisms don't fire first).
# We assert indirectly: Dec 31 6m 900 km with no duct, no foEs
# classifies as :meteor_scatter when the shower window handles
# year-crossing correctly, or :troposcatter when it doesn't.
contact =
create_contact(%{
qso_timestamp: ~U[2025-12-31 10:00:00Z],
band: Decimal.new("50"),
distance_km: Decimal.new("900"),
station1: "W5YR"
})
assert :ok =
MechanismClassifyWorker.perform(%Oban.Job{
args: %{"contact_id" => contact.id}
})
reloaded = Repo.get!(Contact, contact.id)
# Dec 31 is 4 days from Jan 4 — outside the ±3 day window, so we
# should NOT classify as meteor scatter (Quadrantids) here. This
# proves the window math isn't accidentally matching everything.
refute reloaded.propagation_mechanism == "meteor_scatter"
end
end
end