From ec372fd39981f206f7697cd4cc51fb8ad0bc75fb Mon Sep 17 00:00:00 2001
From: Graham McIntire <graham@mcintire.me>
Date: Thu, 4 Jun 2026 14:41:25 -0500
Subject: [PATCH] fix: add geerlingguy.postgresql to requirements.yml (used by
 db.w5isp.com)

---
 ansible/findings.md      | 9 +++------
 ansible/requirements.yml | 6 +++++-
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/ansible/findings.md b/ansible/findings.md
index 2d7c918..79fc260 100644
--- a/ansible/findings.md
+++ b/ansible/findings.md
@@ -44,10 +44,6 @@
 
 ## 🔴 Broken Infrastructure (will fail at runtime)
 
-| # | Issue | Location |
-|---|-------|----------|
-| 8 | **`geerlingguy.postgresql` not in `requirements.yml`** — Role referenced in `playbook.yml:73` for `postgresql_servers` but not installable via `ansible-galaxy`. | `playbook.yml:73`, `requirements.yml` |
-
 ---
 
 ## 🔴 Runtime Crashes (undefined template variables)
@@ -116,6 +112,7 @@ All items in this section have been fixed.
 | 9 | `alpine` role referenced but doesn't exist | Removed `include_role` from `roles/base/tasks/main.yml` |
 | 5 | `general.yml` does not exist | Makefile targets updated to use `playbook.yml`; docker/build targets removed |
 | 6 | No `Dockerfile` at repo root | All docker/build/push targets removed from Makefile |
+| 8 | `geerlingguy.postgresql` not in `requirements.yml` | Added with version pin 3.4.3 |
 | 10 | Orphaned `host_vars/db.aprs.me.yml` with no inventory entry | Deleted (superseded by `db.w5isp.com`) |
 | 12-15 | Undefined template variables (ntpserver, template_run_date, deb_mirror, sshd.*) | Added `| default()` fallbacks |
 | -- | Alpine role reference to non-existent role | Removed from `roles/base/tasks/main.yml` |
@@ -123,7 +120,7 @@ All items in this section have been fixed.
 
 ---
 
-## Recommended Top 2 Fixes
+## Recommended Fix
 
 1. **Rotate all 4 plaintext secrets in `.envrc`** and move to `ansible-vault`
-2. **Add `geerlingguy.postgresql` to `requirements.yml`** — will crash otherwise
+
diff --git a/ansible/requirements.yml b/ansible/requirements.yml
index 32e9179..2e24cd9 100644
--- a/ansible/requirements.yml
+++ b/ansible/requirements.yml
@@ -14,4 +14,8 @@ collections:
   - name: community.mysql
     version: ">=3.0.0"  # Required for Icinga2 MySQL management
   - name: netbox.netbox
-    version: ">=3.0.0"  # Required for NetBox automation
\ No newline at end of file
+    version: ">=3.0.0"  # Required for NetBox automation
+
+roles:
+  - name: geerlingguy.postgresql
+    version: "3.4.3"
\ No newline at end of file