Graham McIntire
ef141d476f
- Fix zero coordinate handling to distinguish between invalid coordinates and valid 0.0 (equator/prime meridian) - Add to_float_safe() function that preserves nil for proper coordinate validation - Add comprehensive coordinate validation with descriptive logging in JavaScript - Make position change threshold configurable via application config (default: 0.001°) - Add extensive test coverage for edge cases including nil coordinates and equator crossing - Improve robustness for real-world APRS coordinate edge cases 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
72 lines
2.6 KiB
Elixir
72 lines
2.6 KiB
Elixir
defmodule AprsmeWeb.InfoLive.PositionChangeTest do
|
|
@moduledoc """
|
|
Tests for position change detection in InfoLive
|
|
"""
|
|
use ExUnit.Case, async: true
|
|
|
|
alias AprsmeWeb.InfoLive.Show
|
|
|
|
describe "position_changed?/2" do
|
|
test "returns true when current packet is nil" do
|
|
new_packet = %{lat: 40.7128, lon: -74.0060}
|
|
assert Show.position_changed_for_test(nil, new_packet)
|
|
end
|
|
|
|
test "returns false when new packet is nil" do
|
|
current_packet = %{lat: 40.7128, lon: -74.0060}
|
|
refute Show.position_changed_for_test(current_packet, nil)
|
|
end
|
|
|
|
test "returns true when position changed significantly" do
|
|
current_packet = %{lat: 40.7128, lon: -74.0060}
|
|
# ~0.8km difference
|
|
new_packet = %{lat: 40.7200, lon: -74.0060}
|
|
assert Show.position_changed_for_test(current_packet, new_packet)
|
|
end
|
|
|
|
test "returns false when position changed minimally" do
|
|
current_packet = %{lat: 40.7128, lon: -74.0060}
|
|
# ~10m difference
|
|
new_packet = %{lat: 40.7129, lon: -74.0061}
|
|
refute Show.position_changed_for_test(current_packet, new_packet)
|
|
end
|
|
|
|
test "returns true when longitude changed significantly" do
|
|
current_packet = %{lat: 40.7128, lon: -74.0060}
|
|
# longitude changed
|
|
new_packet = %{lat: 40.7128, lon: -74.0200}
|
|
assert Show.position_changed_for_test(current_packet, new_packet)
|
|
end
|
|
|
|
test "handles Decimal values" do
|
|
current_packet = %{lat: Decimal.new("40.7128"), lon: Decimal.new("-74.0060")}
|
|
new_packet = %{lat: Decimal.new("40.7200"), lon: Decimal.new("-74.0060")}
|
|
assert Show.position_changed_for_test(current_packet, new_packet)
|
|
end
|
|
|
|
test "handles coordinates at equator/prime meridian (0.0 is valid)" do
|
|
current_packet = %{lat: 0.0, lon: 0.0}
|
|
# Small change from valid 0.0
|
|
new_packet = %{lat: 0.0005, lon: 0.0}
|
|
refute Show.position_changed_for_test(current_packet, new_packet)
|
|
end
|
|
|
|
test "detects change when coordinates become invalid (nil)" do
|
|
current_packet = %{lat: 40.7128, lon: -74.0060}
|
|
new_packet = %{lat: nil, lon: -74.0060}
|
|
assert Show.position_changed_for_test(current_packet, new_packet)
|
|
end
|
|
|
|
test "detects change when coordinates become valid from invalid" do
|
|
current_packet = %{lat: nil, lon: -74.0060}
|
|
new_packet = %{lat: 40.7128, lon: -74.0060}
|
|
assert Show.position_changed_for_test(current_packet, new_packet)
|
|
end
|
|
|
|
test "handles both coordinates being invalid" do
|
|
current_packet = %{lat: nil, lon: nil}
|
|
new_packet = %{lat: nil, lon: nil}
|
|
assert Show.position_changed_for_test(current_packet, new_packet)
|
|
end
|
|
end
|
|
end
|