Graham McIntire
b8a9b8a465
Turned on :error_handling, :underspecs, and :unmatched_returns in mix.exs dialyzer config. The 97 warnings this surfaced were fixed in place rather than suppressed: - unmatched_return (79): explicit discard with `_ = ...` for fire-and-forget side effects (Process.cancel_timer, :ets.new, send/2), and pattern-matched `:ok = ...` for control-plane Phoenix.PubSub subscribe/unsubscribe/broadcast calls so a future return-shape change fails loud. - contract_supertype (18): tightened @spec arg and return types on data_builder, historical_loader, url_params, packet_utils, encoding_utils, aprs_symbol, weather_controller, packet_replay to match each function's actual success typing. No behavioural change. mix compile clean, 1008 tests pass, dialyzer count is now 0.
104 lines
3 KiB
Elixir
104 lines
3 KiB
Elixir
defmodule Aprsme.Cluster.ConnectionManager do
|
|
@moduledoc """
|
|
Manages the APRS-IS connection based on cluster leadership.
|
|
Only starts the connection when this node is elected as leader.
|
|
"""
|
|
use GenServer
|
|
|
|
alias Aprsme.Cluster.LeaderElection
|
|
alias Aprsme.Is.IsSupervisor
|
|
|
|
require Logger
|
|
|
|
def start_link(opts) do
|
|
GenServer.start_link(__MODULE__, opts, name: __MODULE__)
|
|
end
|
|
|
|
@impl true
|
|
def init(_opts) do
|
|
# Subscribe to leadership changes
|
|
:ok = Phoenix.PubSub.subscribe(Aprsme.PubSub, "cluster:leadership")
|
|
|
|
# Check initial leadership state
|
|
delay = Application.get_env(:aprsme, :connection_manager_init_delay, 1000)
|
|
_ = Process.send_after(self(), :check_initial_state, delay)
|
|
|
|
{:ok, %{connection_started: false}}
|
|
end
|
|
|
|
@impl true
|
|
def handle_info(:check_initial_state, state) do
|
|
if leader_check() do
|
|
Logger.info("This node is the leader, starting APRS-IS connection")
|
|
start_aprs_connection()
|
|
{:noreply, %{state | connection_started: true}}
|
|
else
|
|
Logger.info("This node is not the leader, APRS-IS connection will not be started")
|
|
{:noreply, state}
|
|
end
|
|
end
|
|
|
|
@impl true
|
|
def handle_info({:leadership_change, node, became_leader}, state) do
|
|
cond do
|
|
became_leader and node == node() and not state.connection_started ->
|
|
Logger.info("This node became the leader, starting APRS-IS connection")
|
|
start_aprs_connection()
|
|
{:noreply, %{state | connection_started: true}}
|
|
|
|
not became_leader and node == node() and state.connection_started ->
|
|
Logger.info("This node lost leadership, stopping APRS-IS connection")
|
|
stop_aprs_connection()
|
|
{:noreply, %{state | connection_started: false}}
|
|
|
|
true ->
|
|
{:noreply, state}
|
|
end
|
|
end
|
|
|
|
@impl true
|
|
def handle_info(_msg, state), do: {:noreply, state}
|
|
|
|
@impl true
|
|
def terminate(_reason, _state) do
|
|
Phoenix.PubSub.unsubscribe(Aprsme.PubSub, "cluster:leadership")
|
|
:ok
|
|
end
|
|
|
|
defp leader_check do
|
|
LeaderElection.leader?()
|
|
catch
|
|
:exit, _ -> false
|
|
end
|
|
|
|
defp start_aprs_connection do
|
|
# Start the APRS-IS connection supervisor if not already started
|
|
case DynamicSupervisor.start_child(
|
|
Aprsme.DynamicSupervisor,
|
|
{IsSupervisor, []}
|
|
) do
|
|
{:ok, _pid} ->
|
|
Logger.info("APRS-IS connection started successfully")
|
|
|
|
{:error, {:already_started, _pid}} ->
|
|
Logger.info("APRS-IS connection was already running")
|
|
|
|
{:error, reason} ->
|
|
Logger.error("Failed to start APRS-IS connection: #{inspect(reason)}")
|
|
end
|
|
end
|
|
|
|
defp stop_aprs_connection do
|
|
# Find and terminate the APRS-IS connection supervisor
|
|
children = DynamicSupervisor.which_children(Aprsme.DynamicSupervisor)
|
|
|
|
Enum.each(children, fn
|
|
{_, pid, _, [IsSupervisor]} when is_pid(pid) ->
|
|
Logger.info("Stopping APRS-IS connection supervisor")
|
|
DynamicSupervisor.terminate_child(Aprsme.DynamicSupervisor, pid)
|
|
|
|
_ ->
|
|
:ok
|
|
end)
|
|
end
|
|
end
|