aprs.me/lib/aprsme_web/live/map_live
Graham McIntire d9c04f7e0c
Fix code review findings: security, correctness, performance, dead code
Security:
- Add SQL identifier validation to DbOptimizer.analyze_table/vacuum_table
- Move health/readiness routes to non-rate-limited pipeline

Correctness:
- Fix monitor reference leak in StreamingPacketsPubSub (track refs, demonitor on unsubscribe)
- Persist circuit breaker half-open state transitions
- Simplify ShutdownHandler.terminate to avoid pointless Process.send_after

Performance:
- Batch marker removal into single WebSocket event (remove_markers_batch)
- Use Task.Supervisor.start_child for fire-and-forget broadcasts

Dead code removal:
- Remove copy_insert/regular_batch_insert/rows_to_csv from DbOptimizer
- Remove dead packet_pipeline_integration tests
- Remove unused telemetry event detach

Other:
- Fix Callsign.valid? docstring to match permissive behavior
- Fix DatabaseMetrics to delegate instead of hardcoding pool stats
- Add circuit breaker and encoding test coverage
2026-02-19 18:49:27 -06:00
..
bounds_manager.ex clean up warnings 2025-07-16 08:55:46 -05:00
components.ex Fix get_received_at to properly handle Packet structs 2025-10-25 18:43:14 -05:00
data_builder.ex Improve packet pipeline reliability, security, and cleanup efficiency 2026-02-19 14:11:48 -06:00
display_manager.ex Fix code review findings: security, correctness, performance, dead code 2026-02-19 18:49:27 -06:00
historical_loader.ex Improve packet pipeline reliability, security, and cleanup efficiency 2026-02-19 14:11:48 -06:00
index.ex Fix multiple TODO bugs: drain handler, callsign dedup, packet pipeline 2026-02-19 18:27:25 -06:00
navigation.ex fix: Handle database ownership errors gracefully in LiveView tests 2025-07-30 14:29:35 -05:00
packet_batcher.ex updates with parser updates 2025-08-03 09:19:31 -05:00
packet_manager.ex Refactor conditionals to use multi-clause pattern matching 2026-02-10 17:15:49 -06:00
packet_processor.ex Refactor conditionals to use multi-clause pattern matching 2026-02-10 17:15:49 -06:00
packet_store.ex performance improvements 2025-07-14 16:35:58 -05:00
packet_utils.ex Fix all remaining cyclomatic complexity issues 2026-02-09 13:20:54 -06:00
popup_component.ex integrate /:call to main page 2025-07-13 10:36:58 -05:00
rf_path.ex Fix RF path visualization for hovering over track points 2026-02-19 15:41:32 -06:00
url_params.ex fix: Resolve majority of dialyzer type errors 2025-07-30 13:30:21 -05:00
utils.ex major refactor for cleanup 2025-07-14 12:06:10 -05:00