graham/aprs.me
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
aprs.me/lib/aprsme
History
Graham McIntire d9c04f7e0c
Fix code review findings: security, correctness, performance, dead code 
Security:
- Add SQL identifier validation to DbOptimizer.analyze_table/vacuum_table
- Move health/readiness routes to non-rate-limited pipeline

Correctness:
- Fix monitor reference leak in StreamingPacketsPubSub (track refs, demonitor on unsubscribe)
- Persist circuit breaker half-open state transitions
- Simplify ShutdownHandler.terminate to avoid pointless Process.send_after

Performance:
- Batch marker removal into single WebSocket event (remove_markers_batch)
- Use Task.Supervisor.start_child for fire-and-forget broadcasts

Dead code removal:
- Remove copy_insert/regular_batch_insert/rows_to_csv from DbOptimizer
- Remove dead packet_pipeline_integration tests
- Remove unused telemetry event detach

Other:
- Fix Callsign.valid? docstring to match permissive behavior
- Fix DatabaseMetrics to delegate instead of hardcoding pool stats
- Add circuit breaker and encoding test coverage
2026-02-19 18:49:27 -06:00
..
accounts add callsign to users 2025-07-10 16:07:05 -05:00
cluster Fix multiple TODO bugs: drain handler, callsign dedup, packet pipeline 2026-02-19 18:27:25 -06:00
is Fix multiple TODO bugs: drain handler, callsign dedup, packet pipeline 2026-02-19 18:27:25 -06:00
packets Fix all remaining cyclomatic complexity issues 2026-02-09 13:20:54 -06:00
performance Fix packet buffer overflow and system load adjustment issues 2025-07-15 08:16:11 -05:00
telemetry Fix code review findings: security, correctness, performance, dead code 2026-02-19 18:49:27 -06:00
workers Improve packet pipeline reliability, security, and cleanup efficiency 2026-02-19 14:11:48 -06:00
accounts.ex Fix callsign registration to be case-insensitive 2026-02-19 13:20:07 -06:00
application.ex Improve packet pipeline reliability, security, and cleanup efficiency 2026-02-19 14:11:48 -06:00
archiver.ex refactor to use external parser 2025-06-24 14:22:09 -05:00
bad_packet.ex refactor to use external parser 2025-06-24 14:22:09 -05:00
broadcast_task_supervisor.ex Fix code review findings: security, correctness, performance, dead code 2026-02-19 18:49:27 -06:00
cache.ex Fix compile warnings and add comprehensive mobile channel tests 2025-10-25 13:18:55 -05:00
callsign.ex Fix code review findings: security, correctness, performance, dead code 2026-02-19 18:49:27 -06:00
circuit_breaker.ex Fix code review findings: security, correctness, performance, dead code 2026-02-19 18:49:27 -06:00
cleanup_scheduler.ex Complete nested module alias fixes and update Sobelow skips 2026-02-09 11:26:47 -06:00
connection_monitor.ex Fix multiple TODO bugs: drain handler, callsign dedup, packet pipeline 2026-02-19 18:27:25 -06:00
convert.ex more i18n 2025-07-06 10:28:27 -05:00
data_extended.ex update deps 2025-07-16 08:20:20 -05:00
db_optimizer.ex Fix code review findings: security, correctness, performance, dead code 2026-02-19 18:49:27 -06:00
deployment_notifier.ex Fix code formatting 2025-07-28 13:24:16 -05:00
device_cache.ex Fix nesting depth issues in device_cache, packets, and spatial_pubsub 2026-02-09 12:27:34 -06:00
device_identification.ex Refactor conditionals to use multi-clause pattern matching 2026-02-10 17:15:49 -06:00
device_parser.ex refactor 2025-10-12 10:56:49 -05:00
devices.ex refactor to use external parser 2025-06-24 14:22:09 -05:00
devices_seeder.ex Fix potential crashes and unsafe operations throughout the app 2025-07-28 08:35:12 -05:00
dynamic_supervisor.ex Add distributed Erlang clustering for single APRS-IS connection 2025-07-25 10:30:29 -05:00
encoding.ex Reduce cyclomatic complexity in clustering, encoding, and leader_election 2026-02-09 11:57:50 -06:00
encoding_utils.ex fix: Show all packets for tracked callsigns including non-position data 2025-07-30 14:02:44 -05:00
error_handler.ex clean up warnings 2025-07-16 08:55:46 -05:00
geo_utils.ex Increase GPS drift threshold from 15m to 50m 2025-07-21 11:23:37 -05:00
log_sanitizer.ex more tests 2026-02-09 17:21:16 -06:00
mailer.ex refactor to use external parser 2025-06-24 14:22:09 -05:00
migration_lock.ex format 2025-07-27 11:16:16 -05:00
packet.ex Fix all remaining cyclomatic complexity issues 2026-02-09 13:20:54 -06:00
packet_consumer.ex Fix APRS object name extraction for names with special characters 2026-02-19 18:41:37 -06:00
packet_consumer_pool.ex Fix packet buffer overflow with parallel consumer pool 2025-07-19 14:49:52 -05:00
packet_counter.ex performance improvements 2025-07-14 16:35:58 -05:00
packet_field_whitelist.ex fix: Implement comprehensive field whitelist to prevent unknown field errors 2025-08-04 10:52:53 -05:00
packet_pipeline_setup.ex more tests 2026-02-09 17:21:16 -06:00
packet_pipeline_supervisor.ex Fix multiple TODO bugs: drain handler, callsign dedup, packet pipeline 2026-02-19 18:27:25 -06:00
packet_producer.ex Add TCP backpressure to packet pipeline 2026-02-19 15:31:51 -06:00
packet_replay.ex clean up warnings 2025-07-16 08:55:46 -05:00
packet_replay_behaviour.ex refactor to use external parser 2025-06-24 14:22:09 -05:00
packet_sanitizer.ex fix: resolve VARCHAR(255) database errors by migrating to TEXT fields 2025-08-09 16:54:38 -04:00
packets.ex Performance improvements, code cleanup, remove sobelow 2026-02-19 14:51:01 -06:00
packets_behaviour.ex refactor: Remove CachedQueries and rename optimized functions 2025-07-30 13:17:56 -05:00
passcode.ex refactor to use external parser 2025-06-24 14:22:09 -05:00
postgres_notifier.ex Improve info page live updates and fix APRS parser 2025-07-28 15:14:33 -05:00
postgres_types.ex refactor to use external parser 2025-06-24 14:22:09 -05:00
presence.ex refactor to use external parser 2025-06-24 14:22:09 -05:00
rate_limiter.ex update deps 2025-07-16 08:20:20 -05:00
rate_limiter_wrapper.ex Remove Redis dependency from RateLimiterWrapper 2025-10-25 09:44:44 -05:00
regex_cache.ex Reduce nesting depth in regex_cache, connection_monitor, and device_identification 2026-02-09 11:55:51 -06:00
release.ex Complete nested module alias fixes and update Sobelow skips 2026-02-09 11:26:47 -06:00
repo.ex refactor to use external parser 2025-06-24 14:22:09 -05:00
schema.ex refactor to use external parser 2025-06-24 14:22:09 -05:00
shutdown_handler.ex Fix code review findings: security, correctness, performance, dead code 2026-02-19 18:49:27 -06:00
signal_handler.ex fix: Resolve majority of dialyzer type errors 2025-07-30 13:30:21 -05:00
spatial_pubsub.ex Fix multiple TODO bugs: drain handler, callsign dedup, packet pipeline 2026-02-19 18:27:25 -06:00
streaming_packets_pubsub.ex Fix code review findings: security, correctness, performance, dead code 2026-02-19 18:49:27 -06:00
system_monitor.ex Fix packet buffer overflow and system load adjustment issues 2025-07-15 08:16:11 -05:00