graham/aprs.me
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
aprs.me/test/aprsme
History
Graham McIntire 74a19b0640
Fix nesting depth issues in device_cache, packets, and spatial_pubsub 
Reduces function nesting depth to comply with Credo requirements (max depth 2):

- device_cache.ex: Extract pattern matching logic into separate helpers
  (pattern_matches?/2, matches_wildcard_pattern?/2)

- packets.ex: Extract data sanitization logic into separate helpers
  (sanitize_data_extended_attr/1, deep_sanitize_map/1)
  Note: This refactoring improved robustness - invalid data_extended
  values now return validation errors instead of throwing exceptions

- spatial_pubsub.ex: Extract grid cell and client filtering logic
  (remove_client_from_grid_cell/3, update_grid_cell_after_removal/3,
  filter_clients_by_bounds/3, client_contains_point?/3)

- Update test expectation in packets_test.exs to match improved
  error handling behavior (validation_error vs storage_exception)

Fixes 3 Credo nesting depth issues (8 remaining)
2026-02-09 12:27:34 -06:00
..
accounts add callsign to users 2025-07-10 16:07:05 -05:00
cluster Fix credo issues 2026-02-09 11:17:56 -06:00
packets Fix credo warnings and start on design suggestions 2026-02-09 11:23:01 -06:00
workers Migrate background job processing from Oban to Exq 2025-07-26 18:39:50 -05:00
archiver_test.exs refactor to use external parser 2025-06-24 14:22:09 -05:00
bad_packet_test.exs refactor to use external parser 2025-06-24 14:22:09 -05:00
broadcast_task_supervisor_test.exs test: Make tests time-independent and increase timeouts for reliability 2025-08-02 10:07:47 -05:00
callsign_test.exs more permissive callsign parsing 2025-07-12 09:10:49 -05:00
connection_prevention_test.exs refactor to use external parser 2025-06-24 14:22:09 -05:00
convert_test.exs Optimize test suite performance - 32.5% faster execution 2025-07-21 09:23:07 -05:00
data_extended_test.exs fix messaging name 2025-06-24 14:29:47 -05:00
device_identification_test.exs fix: Fix failing tests and improve test reliability 2025-07-30 14:24:21 -05:00
encoding_utils_test.exs update deps 2025-07-16 08:20:20 -05:00
enhanced_parser_test.exs Fix credo issues 2026-02-09 11:17:56 -06:00
geo_utils_test.exs Fix all failing tests 2025-07-25 14:14:04 -05:00
geometry_test.exs fix: Resolve majority of dialyzer type errors 2025-07-30 13:30:21 -05:00
is_test.exs fix: Resolve majority of dialyzer type errors 2025-07-30 13:30:21 -05:00
packet_consumer_test.exs fix: Comprehensive packet processing and test optimization improvements 2025-08-01 17:50:07 -05:00
packet_parsing_test.exs Fix ArgumentError for unknown field :phg in schema 2025-07-28 12:27:19 -05:00
packet_pipeline_integration_test.exs clean up warnings 2025-07-16 08:55:46 -05:00
packet_replay_test.exs refactor to use external parser 2025-06-24 14:22:09 -05:00
packet_test.exs fix: Comprehensive packet processing and test optimization improvements 2025-08-01 17:50:07 -05:00
packet_weather_extraction_test.exs integrate /:call to main page 2025-07-13 10:36:58 -05:00
packets_encoding_test.exs refactor to use external parser 2025-06-24 14:22:09 -05:00
packets_mic_e_test.exs add packet batcher 2025-06-24 15:06:09 -05:00
packets_oldest_test.exs updates with parser updates 2025-08-03 09:19:31 -05:00
packets_test.exs Fix nesting depth issues in device_cache, packets, and spatial_pubsub 2026-02-09 12:27:34 -06:00
packets_weather_test.exs fix geolocation hopefully 2025-07-10 17:12:49 -05:00
passcode_test.exs Optimize test suite performance - 32.5% faster execution 2025-07-21 09:23:07 -05:00
streaming_packets_pubsub_test.exs test: Make tests time-independent and increase timeouts for reliability 2025-08-02 10:07:47 -05:00