aprs.me/lib/aprsme/streaming_packets_pubsub.ex
Graham McIntire a7d934cb5b
Fix APRS-IS connection, packet pipeline, and cleanup reliability
- Handle login send failure in AprsIsConnection instead of crashing
- Close leaked sockets on login failure in Aprsme.Is (init + reconnect)
- Keep rescheduling keepalive timer when disconnected to prevent permanent loss
- Use supervised BroadcastTaskSupervisor instead of unsupervised Task.start
  for packet broadcasting
- Remove racy Process.alive? check in StreamingPacketsPubSub; send/2 to
  dead PIDs is a no-op, :DOWN monitors handle cleanup
- Add dateline wrapping to SpatialPubSub.point_in_bounds? matching
  StreamingPacketsPubSub behavior
- Add bad_packets table cleanup to PacketCleanupWorker
- Add TODO.md with remaining improvements
2026-02-19 13:34:10 -06:00

186 lines
4.6 KiB
Elixir

defmodule Aprsme.StreamingPacketsPubSub do
@moduledoc """
Global PubSub system for streaming APRS packets to subscribers based on geographic bounds.
This module provides efficient real-time packet distribution with geographic filtering,
allowing multiple GenServers to subscribe to packet streams filtered by lat/long bounds.
"""
use GenServer
require Logger
@table_name :streaming_packets_subscribers
# Client API
@doc """
Starts the StreamingPacketsPubSub GenServer.
"""
def start_link(opts \\ []) do
GenServer.start_link(__MODULE__, opts, name: __MODULE__)
end
@doc """
Subscribe to packets within the specified geographic bounds.
## Parameters
- pid: The process to receive packet notifications
- bounds: Map with :north, :south, :east, :west keys defining the geographic area
## Returns
- :ok
"""
def subscribe_to_bounds(pid, bounds) do
GenServer.call(__MODULE__, {:subscribe, pid, bounds})
end
@doc """
Unsubscribe from packet notifications.
"""
def unsubscribe(pid) do
GenServer.call(__MODULE__, {:unsubscribe, pid})
end
@doc """
Broadcast a packet to all subscribers whose bounds contain the packet's location.
"""
def broadcast_packet(packet) do
GenServer.cast(__MODULE__, {:broadcast, packet})
end
@doc """
List all active subscribers and their bounds.
"""
def list_subscribers do
GenServer.call(__MODULE__, :list_subscribers)
end
# Server Callbacks
@impl true
def init(_opts) do
# Create ETS table for fast lookups
:ets.new(@table_name, [:set, :protected, :named_table])
# Monitor subscribers for cleanup
Process.flag(:trap_exit, true)
{:ok, %{}}
end
@impl true
def handle_call({:subscribe, pid, bounds}, _from, state) do
# Validate bounds
if valid_bounds?(bounds) do
# Monitor the subscriber
Process.monitor(pid)
# Store in ETS for fast lookup
:ets.insert(@table_name, {pid, bounds})
{:reply, :ok, state}
else
{:reply, {:error, :invalid_bounds}, state}
end
end
@impl true
def handle_call({:unsubscribe, pid}, _from, state) do
:ets.delete(@table_name, pid)
{:reply, :ok, state}
end
@impl true
def handle_call(:list_subscribers, _from, state) do
subscribers = :ets.tab2list(@table_name)
{:reply, subscribers, state}
end
@impl true
def handle_cast({:broadcast, packet}, state) do
# Get packet coordinates
lat = packet[:latitude] || packet[:lat]
lon = packet[:longitude] || packet[:lon] || packet[:lng]
if lat && lon do
# Find all subscribers whose bounds contain this packet
subscribers =
:ets.select(@table_name, [
{
{:"$1", :"$2"},
[],
[{{:"$1", :"$2"}}]
}
])
# Send to matching subscribers using BroadcastTaskSupervisor
# Collect dead pids to clean up
server_pid = self()
Aprsme.BroadcastTaskSupervisor.async_execute(fn ->
send_to_matching_subscribers(subscribers, lat, lon, packet, server_pid)
end)
end
{:noreply, state}
end
@impl true
def handle_info({:DOWN, _ref, :process, pid, _reason}, state) do
# Clean up subscriber when process dies
:ets.delete(@table_name, pid)
{:noreply, state}
end
# Private functions
defp valid_bounds?(%{north: n, south: s, east: e, west: w}) do
all_bounds_numeric?(n, s, e, w) and
n >= s and
valid_latitude_range?(n) and
valid_latitude_range?(s) and
valid_longitude_range?(e) and
valid_longitude_range?(w)
end
defp valid_bounds?(_), do: false
defp all_bounds_numeric?(n, s, e, w) do
is_number(n) and is_number(s) and is_number(e) and is_number(w)
end
defp valid_latitude_range?(lat) do
lat >= -90 and lat <= 90
end
defp valid_longitude_range?(lon) do
lon >= -180 and lon <= 180
end
defp packet_in_bounds?(lat, lon, %{north: n, south: s, east: e, west: w}) do
lat_in_bounds = lat >= s and lat <= n
# Handle longitude wrap-around at international date line
lon_in_bounds =
if w > e do
# Bounds cross the date line
lon >= w or lon <= e
else
# Normal bounds
lon >= w and lon <= e
end
lat_in_bounds and lon_in_bounds
end
defp send_to_matching_subscribers(subscribers, lat, lon, packet, _server_pid) do
# send/2 to a dead PID is a no-op in Erlang (does not crash).
# Process.monitor :DOWN messages handle cleanup, so no alive? check needed.
subscribers
|> Stream.filter(fn {_pid, bounds} -> packet_in_bounds?(lat, lon, bounds) end)
|> Enum.each(fn {pid, _bounds} ->
send(pid, {:streaming_packet, packet})
end)
end
end