aprs.me/lib/aprsme_web
Graham McIntire d9c04f7e0c
Fix code review findings: security, correctness, performance, dead code
Security:
- Add SQL identifier validation to DbOptimizer.analyze_table/vacuum_table
- Move health/readiness routes to non-rate-limited pipeline

Correctness:
- Fix monitor reference leak in StreamingPacketsPubSub (track refs, demonitor on unsubscribe)
- Persist circuit breaker half-open state transitions
- Simplify ShutdownHandler.terminate to avoid pointless Process.send_after

Performance:
- Batch marker removal into single WebSocket event (remove_markers_batch)
- Use Task.Supervisor.start_child for fire-and-forget broadcasts

Dead code removal:
- Remove copy_insert/regular_batch_insert/rows_to_csv from DbOptimizer
- Remove dead packet_pipeline_integration tests
- Remove unused telemetry event detach

Other:
- Fix Callsign.valid? docstring to match permissive behavior
- Fix DatabaseMetrics to delegate instead of hardcoding pool stats
- Add circuit breaker and encoding test coverage
2026-02-19 18:49:27 -06:00
..
channels Improve packet pipeline reliability, security, and cleanup efficiency 2026-02-19 14:11:48 -06:00
components Fix broken scrolling on non-map pages 2026-02-19 15:08:16 -06:00
controllers Reduce cyclomatic complexity in callsign_json.ex 2026-02-09 12:39:22 -06:00
live Fix code review findings: security, correctness, performance, dead code 2026-02-19 18:49:27 -06:00
plugs Add RemoteIp plug to show real client IP in K8s logs 2026-02-19 15:06:41 -06:00
aprs_symbol.ex Refactor conditionals to use multi-clause pattern matching 2026-02-10 17:15:49 -06:00
endpoint.ex Add RemoteIp plug to show real client IP in K8s logs 2026-02-19 15:06:41 -06:00
gettext.ex more languages 2025-07-06 10:08:58 -05:00
router.ex Fix code review findings: security, correctness, performance, dead code 2026-02-19 18:49:27 -06:00
telemetry.ex Fix code review findings: security, correctness, performance, dead code 2026-02-19 18:49:27 -06:00
time_helpers.ex improve dialyzer 2025-10-13 10:02:15 -05:00
time_utils.ex improve dialyzer 2025-10-13 10:02:15 -05:00
user_auth.ex Fix credo warnings and start on design suggestions 2026-02-09 11:23:01 -06:00
weather_units.ex Refactor conditionals to use multi-clause pattern matching 2026-02-10 17:15:49 -06:00