Graham McIntire
b4f85bf12c
Users could register duplicate callsigns with different casing (e.g., "w1aw" and "W1AW") because the database unique index was case-sensitive. Additionally, live validation showed false "already taken" errors on every keystroke. Changes: - Add case-insensitive unique index using lower(callsign) - Skip callsign uniqueness validation during live form changes - Add test verifying case-insensitive uniqueness enforcement
107 lines
3.2 KiB
Elixir
107 lines
3.2 KiB
Elixir
defmodule AprsmeWeb.UserRegistrationLiveTest do
|
|
use AprsmeWeb.ConnCase
|
|
|
|
import Aprsme.AccountsFixtures
|
|
import Phoenix.LiveViewTest
|
|
|
|
describe "Registration page" do
|
|
test "renders registration page", %{conn: conn} do
|
|
{:ok, _lv, html} = live(conn, ~p"/users/register", on_error: :warn)
|
|
|
|
assert html =~ "Register"
|
|
assert html =~ "Log in"
|
|
end
|
|
|
|
test "redirects if already logged in", %{conn: conn} do
|
|
result =
|
|
conn
|
|
|> log_in_user(user_fixture())
|
|
|> live(~p"/users/register")
|
|
|> follow_redirect(conn, "/")
|
|
|
|
assert {:ok, _conn} = result
|
|
end
|
|
|
|
test "renders errors for invalid data", %{conn: conn} do
|
|
{:ok, lv, _html} = live(conn, ~p"/users/register", on_error: :warn)
|
|
|
|
result =
|
|
lv
|
|
|> element("#registration_form")
|
|
|> render_change(user: %{"email" => "with spaces", "password" => "too short", "callsign" => "INVALID"})
|
|
|
|
assert result =~ "Register"
|
|
assert result =~ "must have the @ sign and no spaces"
|
|
assert result =~ "should be at least 12 character"
|
|
assert result =~ "must be a valid amateur radio callsign"
|
|
end
|
|
end
|
|
|
|
describe "register user" do
|
|
test "creates account and logs the user in", %{conn: conn} do
|
|
{:ok, lv, _html} = live(conn, ~p"/users/register", on_error: :warn)
|
|
|
|
email = unique_user_email()
|
|
form = form(lv, "#registration_form", user: valid_user_attributes(email: email))
|
|
render_submit(form)
|
|
conn = follow_trigger_action(form, conn)
|
|
|
|
assert redirected_to(conn) == ~p"/"
|
|
|
|
# Confirm the user is logged in by checking they can access a protected page
|
|
conn = get(conn, "/users/settings")
|
|
response = html_response(conn, 200)
|
|
assert response =~ "Account Settings"
|
|
assert response =~ "Change Email"
|
|
end
|
|
|
|
test "renders errors for duplicated email", %{conn: conn} do
|
|
{:ok, lv, _html} = live(conn, ~p"/users/register", on_error: :warn)
|
|
|
|
user = user_fixture(%{email: "test@email.com"})
|
|
|
|
result =
|
|
lv
|
|
|> form("#registration_form",
|
|
user: %{"email" => user.email, "password" => "valid_password"}
|
|
)
|
|
|> render_submit()
|
|
|
|
assert result =~ "has already been taken"
|
|
end
|
|
|
|
test "renders errors for duplicated callsign (case-insensitive)", %{conn: conn} do
|
|
{:ok, lv, _html} = live(conn, ~p"/users/register", on_error: :warn)
|
|
|
|
_user = user_fixture(%{callsign: "W1AW"})
|
|
|
|
# Try to register with same callsign in different case
|
|
result =
|
|
lv
|
|
|> form("#registration_form",
|
|
user: %{
|
|
"email" => unique_user_email(),
|
|
"callsign" => "w1aw",
|
|
"password" => "valid_password123"
|
|
}
|
|
)
|
|
|> render_submit()
|
|
|
|
assert result =~ "has already been taken"
|
|
end
|
|
end
|
|
|
|
describe "registration navigation" do
|
|
test "redirects to login page when the Log in button is clicked", %{conn: conn} do
|
|
{:ok, lv, _html} = live(conn, ~p"/users/register", on_error: :warn)
|
|
|
|
{:ok, _login_live, login_html} =
|
|
lv
|
|
|> element(~s|main a[href="/users/log_in"]|)
|
|
|> render_click()
|
|
|> follow_redirect(conn, ~p"/users/log_in")
|
|
|
|
assert login_html =~ "Log in"
|
|
end
|
|
end
|
|
end
|