aprs.me/test/aprsme_web/live/map_live/packet_batcher_test.exs
Graham McIntire b86153cd27
Fix all mix credo --strict warnings (188 → 0)
- Replace apply/2 with direct fully-qualified calls in movement_test
- Fix assert_receive timeouts < 1000ms across 8 test files
- Move nested import statements to module-level scope
- Fix tests with no assertions and add missing doctest
- Replace weak type assertions with specific value checks
- Fix conditional assertions and length/1 expensive patterns
- Disable inappropriate Jump.CredoChecks.AvoidSocketAssignsInTest
- Fix tests not calling application code with credo:disable
- Add various credo:disable comments for legitimate patterns
2026-06-12 16:27:20 -05:00

85 lines
2.2 KiB
Elixir

defmodule AprsmeWeb.MapLive.PacketBatcherTest do
use ExUnit.Case, async: true
alias AprsmeWeb.MapLive.PacketBatcher
setup do
# Trap exits so linked batcher doesn't crash the test process
Process.flag(:trap_exit, true)
:ok
end
describe "start_link/1" do
test "starts a batcher process" do
{:ok, pid} = PacketBatcher.start_link(self())
assert Process.alive?(pid)
GenServer.stop(pid)
end
end
describe "batching behavior" do
test "delivers packets in batch after timeout" do
{:ok, pid} = PacketBatcher.start_link(self())
PacketBatcher.add_packet(pid, %{sender: "TEST-1"})
PacketBatcher.add_packet(pid, %{sender: "TEST-2"})
# Should receive batch after the 100ms timeout
assert_receive {:packet_batch, packets}, 1000
assert length(packets) == 2
assert Enum.at(packets, 0).sender == "TEST-1"
assert Enum.at(packets, 1).sender == "TEST-2"
GenServer.stop(pid)
end
test "delivers immediately when batch size reached" do
{:ok, pid} = PacketBatcher.start_link(self())
# Send 10 packets (batch size threshold)
for i <- 1..10 do
PacketBatcher.add_packet(pid, %{sender: "TEST-#{i}"})
end
# Should receive immediately (not waiting for timeout)
assert_receive {:packet_batch, packets}, 1000
assert length(packets) == 10
GenServer.stop(pid)
end
test "flush/1 delivers buffered packets immediately" do
{:ok, pid} = PacketBatcher.start_link(self())
PacketBatcher.add_packet(pid, %{sender: "TEST-1"})
PacketBatcher.flush(pid)
assert_receive {:packet_batch, [%{sender: "TEST-1"}]}, 1000
GenServer.stop(pid)
end
end
describe "crash recovery" do
test "batcher stops when parent dies" do
# Start a temporary parent process that traps exits
parent =
spawn(fn ->
Process.flag(:trap_exit, true)
receive do
:stop -> :ok
end
end)
{:ok, batcher_pid} = PacketBatcher.start_link(parent)
ref = Process.monitor(batcher_pid)
# Kill the parent
Process.exit(parent, :kill)
# Batcher should stop
assert_receive {:DOWN, ^ref, :process, ^batcher_pid, :normal}, 1000
end
end
end