Commit graph

16 commits

Author SHA1 Message Date
d9c04f7e0c
Fix code review findings: security, correctness, performance, dead code
Security:
- Add SQL identifier validation to DbOptimizer.analyze_table/vacuum_table
- Move health/readiness routes to non-rate-limited pipeline

Correctness:
- Fix monitor reference leak in StreamingPacketsPubSub (track refs, demonitor on unsubscribe)
- Persist circuit breaker half-open state transitions
- Simplify ShutdownHandler.terminate to avoid pointless Process.send_after

Performance:
- Batch marker removal into single WebSocket event (remove_markers_batch)
- Use Task.Supervisor.start_child for fire-and-forget broadcasts

Dead code removal:
- Remove copy_insert/regular_batch_insert/rows_to_csv from DbOptimizer
- Remove dead packet_pipeline_integration tests
- Remove unused telemetry event detach

Other:
- Fix Callsign.valid? docstring to match permissive behavior
- Fix DatabaseMetrics to delegate instead of hardcoding pool stats
- Add circuit breaker and encoding test coverage
2026-02-19 18:49:27 -06:00
fa89c6d3ca
Add TCP backpressure to packet pipeline
When the PacketProducer buffer crosses 80% capacity, signal Aprsme.Is
to switch its TCP socket to passive mode, leveraging TCP flow control
to slow APRS-IS intake. Resume active mode when buffer drains below 30%.

A 30-second safety valve timer auto-resumes if backpressure gets stuck.
Disconnect/reconnect/terminate paths all clear backpressure state.
2026-02-19 15:31:51 -06:00
447a76b3cc
update 2026-02-18 14:14:49 -06:00
9c61e3c374
Fix TelemetryMetricsPrometheus buckets configuration properly
- Add reporter_options with buckets to each distribution metric
- Remove incorrect top-level buckets configuration
- Define buckets array once and reuse for all distribution metrics

The TelemetryMetricsPrometheus library requires buckets to be specified
in reporter_options for each individual distribution metric, not at the
reporter configuration level.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-27 14:24:25 -05:00
9b1fd942c6
Fix TelemetryMetricsPrometheus distribution buckets configuration
- Move buckets configuration from individual metrics to reporter level
- Configure default buckets for all distribution metrics in reporter options
- Remove buckets from individual metric definitions to prevent ArgumentError
- This fixes the pod crash due to "missing required buckets property" error

The TelemetryMetricsPrometheus library requires buckets to be configured
at the reporter level rather than per-metric for distribution types.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-27 14:16:46 -05:00
5f783894a4
Add PostgreSQL and database pool metrics to telemetry
- Create DatabaseMetrics module to collect PostgreSQL statistics
- Add metrics for database connection pool (size, idle, busy, queue)
- Add PostgreSQL connection metrics (active, idle, waiting)
- Add packets table metrics (size, row counts, operations)
- Add query performance metrics from pg_stat_statements
- Create enhanced Grafana dashboard with database visualizations
- Configure periodic measurements to collect metrics every 10 seconds

This provides comprehensive database monitoring including:
- Connection pool health and utilization
- PostgreSQL connection states and bottlenecks
- Table growth and dead tuple ratios
- Query performance statistics
- Database and table sizes

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-27 14:13:17 -05:00
276dc9436b
Fix 'metric type summary is unsupported' warnings
Convert unsupported summary metrics to supported types:
- Use distribution() for latency/duration measurements with appropriate buckets
- Use last_value() for current state metrics (VM memory, queue lengths)
- Use counter() for cumulative metrics (packet counts, errors)

This eliminates the TelemetryMetricsPrometheus warnings about unsupported
summary metric types while maintaining proper metric semantics.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-27 14:08:27 -05:00
c509500320
format 2025-07-27 13:57:33 -05:00
6fdd39dc0e
Fix CI test failures and configuration issues
- Simplify APRS_PORT parsing to avoid syntax errors
- Disable Exq properly in test environment to prevent startup issues
- Disable Prometheus telemetry in test mode to avoid port conflicts
- Update telemetry module to conditionally start Prometheus metrics

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-27 13:51:43 -05:00
863000d6b8
Add Prometheus metrics support to APRS application
- Add telemetry_metrics_prometheus dependency
- Configure Prometheus exporter in telemetry module
- Add metrics endpoint to application endpoint
- Expose /metrics for Prometheus scraping

This enables the application to be monitored by the Prometheus stack.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-27 11:44:11 -05:00
566198afa7
clean up warnings 2025-07-16 08:55:46 -05:00
c431a45b0b
remove duplicate indexes and fix telemetry metrics 2025-07-15 09:17:30 -05:00
8e507702f7
more performance improvements/cleanup 2025-07-14 16:49:55 -05:00
3730b8c848
performance improvements 2025-07-14 16:35:58 -05:00
0beb278371
add packet batcher 2025-06-24 15:06:09 -05:00
ce7c50caa1
refactor to use external parser 2025-06-24 14:22:09 -05:00
Renamed from lib/aprs_web/telemetry.ex (Browse further)