graham/aprs.me
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
1635 commits 1 branch 0 tags 7.3 MiB
Commit graph

5 commits

Author SHA1 Message Date
Graham McIntire
2f09b590e2 fix: resolve all credo issues — 0 warnings, 0 refactoring, 0 readability issues
Some checks are pending
Elixir CI / Build and test (push) Waiting to run
Details
Elixir CI / Dialyzer (push) Waiting to run
Details
Elixir CI / Build and Push Docker Image (push) Blocked by required conditions
Details 
- Add ex_slop credo plugin with all 40 checks
- Remove DualKeyAccess patterns across codebase — atom-only access
- Fix LengthInGuard, LengthComparison, ListLast, ReduceMapPut in lib/
- Disable LengthComparison for test files
- Remove obvious comments and narrator comments (~50)
- Add missing aliases for fully-qualified modules
- Rewrite boilerplate docs in test/support
- Add normalize_keys helpers at API boundaries
 2026-07-29 10:54:07 -05:00
Graham McIntire
e1da1716b1
refactor: split MapLive.Index into focused modules
Some checks failed
Build and Push / Build and Push Docker Image (push) Failing after 2s
Details 
- State (177 lines): mount assigns, defaults, slideover, connection status
- Events (540 lines): 22 handle_event handlers, rate limiting, URL helpers
- Subscriptions (122 lines): PubSub setup, spatial registration, cleanup
- BoundsUpdater (172 lines): bounds pipeline, validation, debouncing
- index.ex: 2,062 -> 1,202 lines (42% reduction)
- Credo: initial_historical_completed, bounds_update_timer added to ignored_assigns
  (consumed by extracted modules, invisible to credo)
- All 361 map_live tests pass across multiple random seeds
- Handoff: marked maintainability #1 as done
 2026-07-26 15:30:08 -05:00
Graham McIntire
b86153cd27
Fix all mix credo --strict warnings (188 → 0) 
- Replace apply/2 with direct fully-qualified calls in movement_test
- Fix assert_receive timeouts < 1000ms across 8 test files
- Move nested import statements to module-level scope
- Fix tests with no assertions and add missing doctest
- Replace weak type assertions with specific value checks
- Fix conditional assertions and length/1 expensive patterns
- Disable inappropriate Jump.CredoChecks.AvoidSocketAssignsInTest
- Fix tests not calling application code with credo:disable
- Add various credo:disable comments for legitimate patterns
 2026-06-12 16:27:20 -05:00
Graham McIntire
da296d852d auto style things 2023-12-17 12:11:57 -06:00
Graham McIntire
d7019de1ed is connection is working 2023-01-26 14:32:49 -06:00