From fd1708e7910e863a4bdac74b90d7ef334c10f3e1 Mon Sep 17 00:00:00 2001
From: Graham McIntire <graham@mcintire.me>
Date: Mon, 16 Jun 2025 11:41:57 -0500
Subject: [PATCH] callsign page fixes

---
 .../components/layouts/root.html.heex         |  2 +-
 lib/aprs_web/live/map_live/callsign_view.ex   | 84 +++++++------------
 .../live/map_live/callsign_view_test.exs      | 34 +++++---
 3 files changed, 55 insertions(+), 65 deletions(-)

diff --git a/lib/aprs_web/components/layouts/root.html.heex b/lib/aprs_web/components/layouts/root.html.heex
index 28a36c1..9a69a2a 100644
--- a/lib/aprs_web/components/layouts/root.html.heex
+++ b/lib/aprs_web/components/layouts/root.html.heex
@@ -4,7 +4,7 @@
     <meta charset="utf-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1" />
     <meta name="csrf-token" content={get_csrf_token()} />
-    <.live_title suffix=" · Phoenix Framework">
+    <.live_title suffix=" · aprs.me">
       {assigns[:page_title] || "Aprs"}
     </.live_title>
     <link phx-track-static rel="stylesheet" href={~p"/assets/app.css"} />
diff --git a/lib/aprs_web/live/map_live/callsign_view.ex b/lib/aprs_web/live/map_live/callsign_view.ex
index aacd22b..e73f12b 100644
--- a/lib/aprs_web/live/map_live/callsign_view.ex
+++ b/lib/aprs_web/live/map_live/callsign_view.ex
@@ -64,8 +64,8 @@ defmodule AprsWeb.MapLive.CallsignView do
 
       # Schedule regular cleanup of old packets from the map
       Process.send_after(self(), :cleanup_old_packets, 60_000)
-      # Schedule initialization of replay after a short delay
-      Process.send_after(self(), :initialize_replay, 2000)
+      # Auto-start replay after a short delay
+      Process.send_after(self(), :auto_start_replay, 2000)
 
       {:ok, socket}
     else
@@ -109,33 +109,6 @@ defmodule AprsWeb.MapLive.CallsignView do
     {:noreply, socket}
   end
 
-  def handle_event("toggle_replay", _params, socket) do
-    if socket.assigns.replay_active do
-      # Stop replay
-      if socket.assigns.replay_timer_ref do
-        Process.cancel_timer(socket.assigns.replay_timer_ref)
-      end
-
-      # Clear historical packets from map
-      socket = push_event(socket, "clear_historical_packets", %{})
-
-      socket =
-        assign(socket,
-          replay_active: false,
-          replay_paused: false,
-          replay_timer_ref: nil,
-          replay_index: 0,
-          historical_packets: %{}
-        )
-
-      {:noreply, socket}
-    else
-      # Start replay
-      socket = start_historical_replay(socket)
-      {:noreply, assign(socket, replay_active: true, replay_paused: false)}
-    end
-  end
-
   def handle_event("pause_replay", _params, socket) do
     if socket.assigns.replay_timer_ref do
       Process.cancel_timer(socket.assigns.replay_timer_ref)
@@ -166,6 +139,15 @@ defmodule AprsWeb.MapLive.CallsignView do
   def handle_event("map_ready", _params, socket) do
     socket = assign(socket, map_ready: true)
 
+    # Auto-start replay if it hasn't been started yet
+    socket =
+      if socket.assigns.replay_started do
+        socket
+      else
+        socket = start_historical_replay(socket)
+        assign(socket, replay_started: true, replay_active: true)
+      end
+
     # If we have a pending geolocation, zoom to it now
     socket =
       if socket.assigns.pending_geolocation do
@@ -214,12 +196,17 @@ defmodule AprsWeb.MapLive.CallsignView do
         socket = push_event(socket, "zoom_to_location", %{lat: lat, lng: lng, zoom: 12})
         {:noreply, socket}
 
-      :initialize_replay ->
-        # Only start replay if it hasn't been started yet
+      :auto_start_replay ->
+        # Auto-start replay if it hasn't been started yet and map is ready
         if not socket.assigns.replay_started and socket.assigns.map_ready do
           socket = start_historical_replay(socket)
-          {:noreply, assign(socket, replay_started: true)}
+          {:noreply, assign(socket, replay_started: true, replay_active: true)}
         else
+          # If map isn't ready yet, try again in a bit
+          if not socket.assigns.map_ready do
+            Process.send_after(self(), :auto_start_replay, 1000)
+          end
+
           {:noreply, socket}
         end
 
@@ -583,15 +570,8 @@ defmodule AprsWeb.MapLive.CallsignView do
       </div>
     </div>
 
-    <div class="replay-controls">
-      <button
-        class={"replay-button #{if @replay_active, do: "active", else: ""}"}
-        phx-click="toggle_replay"
-      >
-        {if @replay_active, do: "Stop Replay", else: "Start Replay"}
-      </button>
-
-      <%= if @replay_active do %>
+    <%= if @replay_active do %>
+      <div class="replay-controls">
         <button class="replay-button" phx-click="pause_replay">
           {if @replay_paused, do: "Resume", else: "Pause"}
         </button>
@@ -608,8 +588,8 @@ defmodule AprsWeb.MapLive.CallsignView do
             name="speed"
           />x
         </div>
-      <% end %>
-    </div>
+      </div>
+    <% end %>
 
     <button class="locate-button" phx-click="locate_me" title="Find my location">
       🎯
@@ -617,9 +597,9 @@ defmodule AprsWeb.MapLive.CallsignView do
 
     <%= if map_size(@visible_packets) == 0 and not @replay_active do %>
       <div class="empty-state">
-        <h3>No Recent Packets</h3>
+        <h3>Loading Historical Data</h3>
         <p>
-          No packets found for {@callsign} in the last hour. Try starting a historical replay to see older data.
+          Loading packet history for {@callsign}...
         </p>
       </div>
     <% end %>
@@ -666,23 +646,23 @@ defmodule AprsWeb.MapLive.CallsignView do
   end
 
   defp start_historical_replay(socket) do
-    # Fetch historical packets for the specific callsign
-    one_hour_ago = DateTime.add(DateTime.utc_now(), -3600, :second)
-    six_hours_ago = DateTime.add(DateTime.utc_now(), -21_600, :second)
+    # Fetch historical packets for the specific callsign from the last hour
+    now = DateTime.utc_now()
+    one_hour_ago = DateTime.add(now, -3600, :second)
 
     packets =
       fetch_historical_packets_for_callsign(
         socket.assigns.callsign,
-        six_hours_ago,
-        one_hour_ago
+        one_hour_ago,
+        now
       )
 
     socket =
       assign(socket,
         replay_packets: packets,
         replay_index: 0,
-        replay_start_time: six_hours_ago,
-        replay_end_time: one_hour_ago,
+        replay_start_time: one_hour_ago,
+        replay_end_time: now,
         historical_packets: %{}
       )
 
diff --git a/test/aprs_web/live/map_live/callsign_view_test.exs b/test/aprs_web/live/map_live/callsign_view_test.exs
index 747e8c5..4a32834 100644
--- a/test/aprs_web/live/map_live/callsign_view_test.exs
+++ b/test/aprs_web/live/map_live/callsign_view_test.exs
@@ -19,11 +19,11 @@ defmodule AprsWeb.MapLive.CallsignViewTest do
       assert html =~ "📡 W5ISP-9"
     end
 
-    test "shows empty state when no packets found", %{conn: conn} do
+    test "shows loading state when no packets found", %{conn: conn} do
       {:ok, _view, html} = live(conn, "/TESTCALL-1")
 
-      assert html =~ "No Recent Packets"
-      assert html =~ "No packets found for TESTCALL-1"
+      assert html =~ "Loading Historical Data"
+      assert html =~ "Loading packet history for TESTCALL-1"
     end
 
     test "handles callsign without SSID", %{conn: conn} do
@@ -32,23 +32,33 @@ defmodule AprsWeb.MapLive.CallsignViewTest do
       assert html =~ "📡 W5ISP"
     end
 
-    test "has replay controls", %{conn: conn} do
+    test "auto-starts replay and has pause controls", %{conn: conn} do
       {:ok, view, _html} = live(conn, "/W5ISP-9")
 
-      assert has_element?(view, "button", "Start Replay")
+      # Simulate map ready event to trigger auto-replay
+      render_hook(view, "map_ready", %{})
+
+      # Should have pause controls but no start/stop replay button
+      assert has_element?(view, "button", "Pause")
+      refute has_element?(view, "button", "Start Replay")
     end
 
-    test "can start and stop replay", %{conn: conn} do
+    test "can pause and resume replay", %{conn: conn} do
       {:ok, view, _html} = live(conn, "/W5ISP-9")
 
-      # Start replay
-      view |> element("button", "Start Replay") |> render_click()
-      assert has_element?(view, "button", "Stop Replay")
+      # Trigger map ready to start auto-replay
+      render_hook(view, "map_ready", %{})
+
+      # Should have pause button available
       assert has_element?(view, "button", "Pause")
 
-      # Stop replay
-      view |> element("button", "Stop Replay") |> render_click()
-      assert has_element?(view, "button", "Start Replay")
+      # Pause replay
+      view |> element("button", "Pause") |> render_click()
+      assert has_element?(view, "button", "Resume")
+
+      # Resume replay
+      view |> element("button", "Resume") |> render_click()
+      assert has_element?(view, "button", "Pause")
     end
 
     test "handles locate me button", %{conn: conn} do