From c711caff4e842edfffd681069ef208cb2ae91f93 Mon Sep 17 00:00:00 2001
From: Graham McIntire <graham@mcintire.me>
Date: Tue, 5 May 2026 13:20:58 -0500
Subject: [PATCH] Remove AppSignal; fix decrement trigger and stale test
 assertions

- Delete config/appsignal.exs (was never wired into mix.exs or any
  other config file)
- Migration: fix decrement_packet_sequence trigger to handle the case
  where currval() hasn't been called in the current DB session, matching
  the same exception handling already present in get_packet_count()
- Fix get_historical_packet_count test: invalid non-list bounds are
  silently ignored (no error), so assert is_integer not count == 0
- Add Repo.delete_all(Packet) setup blocks in PacketsOldestTest and
  PacketConsumerTest to clear any committed DB state before tests that
  depend on an empty packets table
---
 config/appsignal.exs                          | 13 -------
 ..._fix_decrement_packet_sequence_trigger.exs | 35 +++++++++++++++++++
 test/aprsme/packet_consumer_test.exs          |  5 +++
 test/aprsme/packets_oldest_test.exs           | 10 ++++--
 test/aprsme/packets_test.exs                  |  5 ++-
 5 files changed, 50 insertions(+), 18 deletions(-)
 delete mode 100644 config/appsignal.exs
 create mode 100644 priv/repo/migrations/20260505000000_fix_decrement_packet_sequence_trigger.exs

diff --git a/config/appsignal.exs b/config/appsignal.exs
deleted file mode 100644
index cbb4d82..0000000
--- a/config/appsignal.exs
+++ /dev/null
@@ -1,13 +0,0 @@
-import Config
-
-# Only enable AppSignal in production
-# Use config_env() which is available at runtime
-env = config_env()
-active = env == :prod
-
-config :appsignal, :config,
-  otp_app: :aprsme,
-  name: "aprsme",
-  push_api_key: "070601ca-6102-4214-82ad-d0c40df7f6ee",
-  env: env,
-  active: active
diff --git a/priv/repo/migrations/20260505000000_fix_decrement_packet_sequence_trigger.exs b/priv/repo/migrations/20260505000000_fix_decrement_packet_sequence_trigger.exs
new file mode 100644
index 0000000..347a489
--- /dev/null
+++ b/priv/repo/migrations/20260505000000_fix_decrement_packet_sequence_trigger.exs
@@ -0,0 +1,35 @@
+defmodule Aprsme.Repo.Migrations.FixDecrementPacketSequenceTrigger do
+  use Ecto.Migration
+
+  def up do
+    execute """
+    CREATE OR REPLACE FUNCTION decrement_packet_sequence()
+    RETURNS TRIGGER AS $$
+    DECLARE
+      current_val BIGINT;
+    BEGIN
+      BEGIN
+        current_val := currval('packet_count_seq');
+      EXCEPTION
+        WHEN object_not_in_prerequisite_state THEN
+          SELECT last_value INTO current_val FROM packet_count_seq;
+      END;
+      PERFORM setval('packet_count_seq', GREATEST(0, current_val - 1), true);
+      RETURN OLD;
+    END;
+    $$ LANGUAGE plpgsql;
+    """
+  end
+
+  def down do
+    execute """
+    CREATE OR REPLACE FUNCTION decrement_packet_sequence()
+    RETURNS TRIGGER AS $$
+    BEGIN
+      PERFORM setval('packet_count_seq', GREATEST(0, currval('packet_count_seq') - 1), true);
+      RETURN OLD;
+    END;
+    $$ LANGUAGE plpgsql;
+    """
+  end
+end
diff --git a/test/aprsme/packet_consumer_test.exs b/test/aprsme/packet_consumer_test.exs
index a670cc1..a8a8f73 100644
--- a/test/aprsme/packet_consumer_test.exs
+++ b/test/aprsme/packet_consumer_test.exs
@@ -340,6 +340,11 @@ defmodule Aprsme.PacketConsumerTest do
   end
 
   describe "handle_events/3 with stream processing" do
+    setup do
+      Repo.delete_all(Packet)
+      :ok
+    end
+
     test "processes packets using streams without memory accumulation" do
       # Create test packets
       events =
diff --git a/test/aprsme/packets_oldest_test.exs b/test/aprsme/packets_oldest_test.exs
index 0dbc3a9..536b721 100644
--- a/test/aprsme/packets_oldest_test.exs
+++ b/test/aprsme/packets_oldest_test.exs
@@ -1,10 +1,16 @@
 defmodule Aprsme.PacketsOldestTest do
   use Aprsme.DataCase
 
+  alias Aprsme.Packet
   alias Aprsme.Packets
   alias Aprsme.Repo
 
   describe "get_oldest_packet_timestamp/0" do
+    setup do
+      Repo.delete_all(Packet)
+      :ok
+    end
+
     test "returns nil when no packets exist" do
       assert is_nil(Packets.get_oldest_packet_timestamp())
     end
@@ -69,8 +75,8 @@ defmodule Aprsme.PacketsOldestTest do
       received_at: received_at
     }
 
-    %Aprsme.Packet{}
-    |> Aprsme.Packet.changeset(packet_data)
+    %Packet{}
+    |> Packet.changeset(packet_data)
     |> Repo.insert()
   end
 end
diff --git a/test/aprsme/packets_test.exs b/test/aprsme/packets_test.exs
index 93ff1ca..87215a2 100644
--- a/test/aprsme/packets_test.exs
+++ b/test/aprsme/packets_test.exs
@@ -1187,10 +1187,9 @@ defmodule Aprsme.PacketsTest do
       assert count >= 2
     end
 
-    test "returns 0 on error" do
-      # Invalid bounds should not crash
+    test "does not crash with invalid bounds" do
       count = Packets.get_historical_packet_count(%{bounds: "invalid"})
-      assert count == 0
+      assert is_integer(count) and count >= 0
     end
   end