graham/aprs.me
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix mobile channel update_bounds nil handling

Browse source 
Replace 'with' clause that was failing when socket.assigns[:subscribed]
returned nil. Now properly checks subscription status using Map.get with
a default value of false to prevent WithClauseError.

Fixes error: no with clause matching: nil

Generated with Claude Code https://claude.com/claude-code
This commit is contained in:
Graham McIntire 2025-10-25 12:48:34 -05:00
parent d6c3ada6c4
commit 9509c49429
No known key found for this signature in database
1 changed files with 22 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
lib/aprsme_web/channels/mobile_channel.ex
View file

@ -102,28 +102,30 @@ defmodule AprsmeWeb.MobileChannel do
west: ensure_float(west)
}
# Validate bounds
with :ok <- validate_bounds(bounds),
true <- socket.assigns[:subscribed] do
# Unsubscribe from old bounds
if socket.assigns[:bounds] do
Aprsme.StreamingPacketsPubSub.unsubscribe_from_bounds(self(), socket.assigns.bounds)
# Check if subscribed
if Map.get(socket.assigns, :subscribed, false) do
# Validate bounds
case validate_bounds(bounds) do
:ok ->
# Unsubscribe from old bounds
if socket.assigns[:bounds] do
Aprsme.StreamingPacketsPubSub.unsubscribe_from_bounds(self(), socket.assigns.bounds)
end
# Subscribe to new bounds
Aprsme.StreamingPacketsPubSub.subscribe_to_bounds(self(), bounds)
socket = assign(socket, :bounds, bounds)
Logger.debug("Mobile client #{socket.assigns.client_id} updated bounds: #{inspect(bounds)}")
{:reply, {:ok, %{bounds: bounds, message: "Bounds updated"}}, socket}
{:error, reason} ->
{:reply, {:error, %{message: reason}}, socket}
end
# Subscribe to new bounds
Aprsme.StreamingPacketsPubSub.subscribe_to_bounds(self(), bounds)
socket = assign(socket, :bounds, bounds)
Logger.debug("Mobile client #{socket.assigns.client_id} updated bounds: #{inspect(bounds)}")
{:reply, {:ok, %{bounds: bounds, message: "Bounds updated"}}, socket}
else
{:error, reason} ->
{:reply, {:error, %{message: reason}}, socket}
false ->
{:reply, {:error, %{message: "Not subscribed. Call subscribe_bounds first."}}, socket}
{:reply, {:error, %{message: "Not subscribed. Call subscribe_bounds first."}}, socket}
end
end