From 8015964dea32a328f92237fd9bdbb6dfe5ded09e Mon Sep 17 00:00:00 2001 From: Graham McIntire Date: Mon, 4 Aug 2025 21:32:57 -0500 Subject: [PATCH] fix test --- CLAUDE.md | 9 +++++++++ test/integration/historical_loading_integration_test.exs | 7 ++++--- vendor/aprs | 2 +- 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/CLAUDE.md b/CLAUDE.md index a05dd33..3c4e686 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -132,6 +132,15 @@ Tests use comprehensive mocking to prevent external connections: **REMEMBER**: Always run `mix format` before every commit - this is non-negotiable and must become automatic habit. +## Git Commit Messages + +When creating git commits: +- Write clear, concise commit messages following conventional commit format (e.g., `feat:`, `fix:`, `refactor:`, `docs:`) +- Focus on the "why" rather than the "what" in commit messages +- **DO NOT** add "Generated with Claude Code" or similar attribution to commit messages +- **DO NOT** add Co-Authored-By lines for Claude +- Keep commit messages professional and focused solely on the code changes + ## Important Documentation Updates - **MANDATORY**: Whenever you implement improvements or changes to the system: diff --git a/test/integration/historical_loading_integration_test.exs b/test/integration/historical_loading_integration_test.exs index 32afb60..4292bf7 100644 --- a/test/integration/historical_loading_integration_test.exs +++ b/test/integration/historical_loading_integration_test.exs @@ -115,18 +115,19 @@ defmodule AprsmeWeb.HistoricalLoadingIntegrationTest do # Try to find markers with a more specific selector # Leaflet markers have specific classes markers = all(session, css(".leaflet-marker-icon")) + marker_count = length(markers) - if length(markers) == 0 do + if marker_count == 0 do # Take screenshot for debugging take_screenshot(session, name: "no_markers_found") # Check if there are any error messages - page_text = text(session) + page_text = Wallaby.Browser.text(session) IO.puts("Page text: #{page_text}") end # Check that markers are present on the map - assert length(markers) > 0, "Expected to find markers on the map, but found #{length(markers)}" + assert marker_count > 0, "Expected to find markers on the map, but found #{marker_count}" # Verify at least 2 markers are present (our test packets) marker_count = diff --git a/vendor/aprs b/vendor/aprs index a1c1fba..9d29440 160000 --- a/vendor/aprs +++ b/vendor/aprs @@ -1 +1 @@ -Subproject commit a1c1fba30f600e400a14fc29e7b9f5546adb472e +Subproject commit 9d2944000622706320b2228f465804ba91ce12a8