From 7f4cc743484804d0edf6e8b53fe3a6e0529df8c4 Mon Sep 17 00:00:00 2001
From: Fly Dev <dev@fly.io>
Date: Mon, 23 Jun 2025 14:50:03 +0000
Subject: [PATCH] Clean up remaining test files and remove unused mocks

- Remove unused mocks.ex file
- Clean up time_helpers_test.exs
- Complete test suite cleanup after fixing all errors and warnings
---
 test/aprs_web/time_helpers_test.exs | 20 ++++++-------
 test/support/mocks.ex               | 46 -----------------------------
 2 files changed, 10 insertions(+), 56 deletions(-)
 delete mode 100644 test/support/mocks.ex

diff --git a/test/aprs_web/time_helpers_test.exs b/test/aprs_web/time_helpers_test.exs
index 33ba00e..154efb8 100644
--- a/test/aprs_web/time_helpers_test.exs
+++ b/test/aprs_web/time_helpers_test.exs
@@ -10,52 +10,52 @@ defmodule AprsWeb.TimeHelpersTest do
     end
 
     test "returns '1 minute ago' for times a minute ago" do
-      one_minute_ago = DateTime.utc_now() |> DateTime.add(-61, :second)
+      one_minute_ago = DateTime.add(DateTime.utc_now(), -61, :second)
       assert TimeHelpers.time_ago_in_words(one_minute_ago) == "1 minute ago"
     end
 
     test "returns 'X minutes ago' for times a few minutes ago" do
-      five_minutes_ago = DateTime.utc_now() |> DateTime.add(-300, :second)
+      five_minutes_ago = DateTime.add(DateTime.utc_now(), -300, :second)
       assert TimeHelpers.time_ago_in_words(five_minutes_ago) == "5 minutes ago"
     end
 
     test "returns '1 hour ago' for times an hour ago" do
-      one_hour_ago = DateTime.utc_now() |> DateTime.add(-3601, :second)
+      one_hour_ago = DateTime.add(DateTime.utc_now(), -3601, :second)
       assert TimeHelpers.time_ago_in_words(one_hour_ago) == "1 hour ago"
     end
 
     test "returns 'X hours ago' for times a few hours ago" do
-      five_hours_ago = DateTime.utc_now() |> DateTime.add(-18_000, :second)
+      five_hours_ago = DateTime.add(DateTime.utc_now(), -18_000, :second)
       assert TimeHelpers.time_ago_in_words(five_hours_ago) == "5 hours ago"
     end
 
     test "returns '1 day ago' for times a day ago" do
-      one_day_ago = DateTime.utc_now() |> DateTime.add(-86_401, :second)
+      one_day_ago = DateTime.add(DateTime.utc_now(), -86_401, :second)
       assert TimeHelpers.time_ago_in_words(one_day_ago) == "1 day ago"
     end
 
     test "returns 'X days ago' for times a few days ago" do
-      five_days_ago = DateTime.utc_now() |> DateTime.add(-432_000, :second)
+      five_days_ago = DateTime.add(DateTime.utc_now(), -432_000, :second)
       assert TimeHelpers.time_ago_in_words(five_days_ago) == "5 days ago"
     end
 
     test "returns '1 month ago' for times a month ago" do
-      one_month_ago = DateTime.utc_now() |> DateTime.add(-2_592_001, :second)
+      one_month_ago = DateTime.add(DateTime.utc_now(), -2_592_001, :second)
       assert TimeHelpers.time_ago_in_words(one_month_ago) == "1 month ago"
     end
 
     test "returns 'X months ago' for times a few months ago" do
-      five_months_ago = DateTime.utc_now() |> DateTime.add(-12_960_000, :second)
+      five_months_ago = DateTime.add(DateTime.utc_now(), -12_960_000, :second)
       assert TimeHelpers.time_ago_in_words(five_months_ago) == "5 months ago"
     end
 
     test "returns '1 year ago' for times a year ago" do
-      one_year_ago = DateTime.utc_now() |> DateTime.add(-31_536_001, :second)
+      one_year_ago = DateTime.add(DateTime.utc_now(), -31_536_001, :second)
       assert TimeHelpers.time_ago_in_words(one_year_ago) == "1 year ago"
     end
 
     test "returns 'X years ago' for times a few years ago" do
-      two_years_ago = DateTime.utc_now() |> DateTime.add(-63_072_002, :second)
+      two_years_ago = DateTime.add(DateTime.utc_now(), -63_072_002, :second)
       assert TimeHelpers.time_ago_in_words(two_years_ago) == "2 years ago"
     end
   end
diff --git a/test/support/mocks.ex b/test/support/mocks.ex
deleted file mode 100644
index 0e93b3e..0000000
--- a/test/support/mocks.ex
+++ /dev/null
@@ -1,46 +0,0 @@
-# Mocks are defined in test_helper.exs
-# This file can be used for mock implementations or test utilities
-
-defmodule Aprs.MockHelpers do
-  @moduledoc """
-  Helper functions for setting up mocks in tests
-  """
-
-  import Mox
-
-  @doc """
-  Stubs the PacketsMock to return an empty list for get_packets_for_replay.
-  Use this in tests that don't care about historical packets but use MapLive.
-  """
-  def stub_packets_mock do
-    stub(Aprs.PacketsMock, :get_packets_for_replay, fn _opts -> [] end)
-  end
-
-  @doc """
-  Sets up an expectation for PacketsMock with custom return value.
-  """
-  def expect_packets_for_replay(packets) do
-    stub(Aprs.PacketsMock, :get_packets_for_replay, fn _opts ->
-      packets
-    end)
-  end
-
-  @doc """
-  Sets up an expectation for PacketsMock with filtering based on bounds.
-  """
-  def expect_packets_for_replay_with_bounds(packets) do
-    stub(Aprs.PacketsMock, :get_packets_for_replay, fn opts ->
-      case opts[:bounds] do
-        [west, south, east, north] ->
-          Enum.filter(packets, fn packet ->
-            packet.has_position &&
-              packet.lat >= south && packet.lat <= north &&
-              packet.lon >= west && packet.lon <= east
-          end)
-
-        _ ->
-          packets
-      end
-    end)
-  end
-end