Address PR feedback: Add defensive handling and documentation

- Add nil handling for @last_update_at in template with fallback message
- Add documentation comments explaining timestamp update logic
- Improve code clarity based on review feedback

Addresses suggestions from automated PR review.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Graham McIntire 2025-07-25 14:26:58 -05:00
parent d42e15c159
commit 7b8b417673
No known key found for this signature in database
2 changed files with 13 additions and 6 deletions

View file

@ -200,7 +200,8 @@ defmodule AprsmeWeb.MapLive.Index do
overlay_callsign: "",
# Slideover state - will be set based on screen size
slideover_open: true,
# Track when last update occurred for display
# Track when last update occurred for real-time display in map sidebar
# Updated when packets are processed or map bounds change
last_update_at: DateTime.utc_now()
)
end
@ -1311,10 +1312,14 @@ defmodule AprsmeWeb.MapLive.Index do
<span class="font-medium">{gettext("Last Update")}</span>
</div>
<div class="text-xs text-slate-500">
<div class="font-mono">{time_ago_in_words(@last_update_at)}</div>
<div class="font-mono text-slate-400">
{Calendar.strftime(@last_update_at, "%Y-%m-%d %H:%M UTC")}
</div>
<%= if @last_update_at do %>
<div class="font-mono">{time_ago_in_words(@last_update_at)}</div>
<div class="font-mono text-slate-400">
{Calendar.strftime(@last_update_at, "%Y-%m-%d %H:%M UTC")}
</div>
<% else %>
<div class="font-mono text-slate-500">No updates yet</div>
<% end %>
</div>
</div>
@ -1641,6 +1646,7 @@ defmodule AprsmeWeb.MapLive.Index do
socket
|> assign(map_bounds: map_bounds, packet_state: updated_packet_state)
|> assign(needs_initial_historical_load: false)
# Update last update timestamp when map bounds change - this triggers data refresh
|> assign(last_update_at: DateTime.utc_now())
# Load historical packets for the new bounds (now socket.assigns.map_bounds is correct)

View file

@ -39,7 +39,8 @@ defmodule AprsmeWeb.MapLive.PacketProcessor do
# Handle packet visibility logic
socket = handle_packet_visibility(packet, lat, lon, callsign_key, socket)
# Update last update timestamp for display purposes
# Update last update timestamp for real-time display in map sidebar
# This timestamp is shown to users to indicate when data was last refreshed
socket = assign(socket, :last_update_at, DateTime.utc_now())
{:noreply, socket}