graham/aprs.me
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor: MobileChannel callsign search pattern via function dispatch

Browse source 
build_search_pattern/1 picks between SQL-wildcard (when the query
contains `*`) and prefix-match (SSID-friendly) forms via two function
heads instead of an inline `if`. The transform is now isolated and
obviously boolean-dispatched at the call site.
This commit is contained in:
Graham McIntire 2026-04-23 14:49:57 -05:00
parent 5a8f30916e
commit 0cbe93f8db
No known key found for this signature in database
GPG key ID: F4ABF488E6029E59
1 changed files with 11 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
lib/aprsme_web/channels/mobile_channel.ex
View file

@ -353,6 +353,16 @@ defmodule AprsmeWeb.MobileChannel do
defp ensure_float(_value), do: nil defp ensure_float(_value), do: nil
# Dispatch on wildcard presence. `*` is the user-facing wildcard; SQL LIKE
# uses `%`. Without a wildcard, match callsigns that start with the query
# so SSID searches like "K5ABC" match "K5ABC-9".
defp build_search_pattern(query) do
build_search_pattern_for(String.contains?(query, "*"), query)
end
defp build_search_pattern_for(true, query), do: String.replace(query, "*", "%")
defp build_search_pattern_for(false, query), do: "#{query}%"
defp ensure_integer(value, _default) when is_integer(value), do: value defp ensure_integer(value, _default) when is_integer(value), do: value
defp ensure_integer(value, default) when is_binary(value) do defp ensure_integer(value, default) when is_binary(value) do
@ -471,16 +481,7 @@ defmodule AprsmeWeb.MobileChannel do
Logger.info("Searching for callsign: #{query}") Logger.info("Searching for callsign: #{query}")
# Build search pattern - support wildcard with * pattern = build_search_pattern(query)
pattern =
if String.contains?(query, "*") do
# Convert * to SQL % wildcard
String.replace(query, "*", "%")
else
# If no wildcard, search for exact match or with SSID
"#{query}%"
end
Logger.info("Search pattern: #{pattern}") Logger.info("Search pattern: #{pattern}")
# Query for matching callsigns - optimized version # Query for matching callsigns - optimized version