From 0c90a47f9ad29618938893ea074b9b7db28a933d Mon Sep 17 00:00:00 2001 From: Graham McIntire Date: Thu, 4 Jun 2026 18:00:03 -0500 Subject: [PATCH] update stuff --- lib/aprsme_web/router.ex | 2 +- test/aprsme_web/live/map_live/historical_loading_test.exs | 4 ++-- test/aprsme_web/live/map_live/movement_test.exs | 5 +++++ test/aprsme_web/live/map_live/url_params_test.exs | 1 - test/aprsme_web/live/packets_live/index_test.exs | 2 -- test/aprsme_web/telemetry_test.exs | 2 +- test/support/aprs_is_mock.ex | 2 -- 7 files changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/aprsme_web/router.ex b/lib/aprsme_web/router.ex index e4f9eb4..8f867f0 100644 --- a/lib/aprsme_web/router.ex +++ b/lib/aprsme_web/router.ex @@ -22,7 +22,7 @@ defmodule AprsmeWeb.Router do plug :put_secure_browser_headers, %{ "content-security-policy" => - "default-src 'self'; script-src 'self' 'unsafe-inline' 'unsafe-eval' https://js.sentry-cdn.com https://unpkg.com https://cdn.jsdelivr.net https://cdnjs.cloudflare.com; style-src 'self' 'unsafe-inline' https://unpkg.com; img-src 'self' data: https: http: blob:; font-src 'self' data:; connect-src 'self' wss: https://*.ingest.sentry.io https://*.sentry.io https://nominatim.openstreetmap.org https://tile.openstreetmap.org https://*.tile.openstreetmap.org https://*.tile.openstreetmap.de https://*.basemaps.cartocdn.com; media-src 'self'; object-src 'none'; frame-ancestors 'none'; base-uri 'self'; form-action 'self'; frame-src 'self'; manifest-src 'self'; worker-src 'self' blob:" + "default-src 'self'; script-src 'self' 'unsafe-inline' 'unsafe-eval' https://js.sentry-cdn.com https://unpkg.com https://cdn.jsdelivr.net https://cdnjs.cloudflare.com https://a.w5isp.com; style-src 'self' 'unsafe-inline' https://unpkg.com; img-src 'self' data: https: http: blob:; font-src 'self' data:; connect-src 'self' wss: https://*.ingest.sentry.io https://*.sentry.io https://nominatim.openstreetmap.org https://tile.openstreetmap.org https://*.tile.openstreetmap.org https://*.tile.openstreetmap.de https://*.basemaps.cartocdn.com https://a.w5isp.com; media-src 'self'; object-src 'none'; frame-ancestors 'none'; base-uri 'self'; form-action 'self'; frame-src 'self'; manifest-src 'self'; worker-src 'self' blob:" } plug :fetch_current_user diff --git a/test/aprsme_web/live/map_live/historical_loading_test.exs b/test/aprsme_web/live/map_live/historical_loading_test.exs index 56c486a..4cbffec 100644 --- a/test/aprsme_web/live/map_live/historical_loading_test.exs +++ b/test/aprsme_web/live/map_live/historical_loading_test.exs @@ -37,7 +37,7 @@ defmodule AprsmeWeb.MapLive.HistoricalLoadingTest do }) # Create an old packet that should not be loaded - _old_packet = + old_packet = packet_fixture(%{ sender: "TEST3", base_callsign: "TEST3", @@ -77,7 +77,7 @@ defmodule AprsmeWeb.MapLive.HistoricalLoadingTest do packet_ids = Enum.map(recent_packets, & &1.id) assert packet1.id in packet_ids assert packet2.id in packet_ids - refute _old_packet.id in packet_ids + refute old_packet.id in packet_ids end test "loads historical packets with custom historical hours setting", %{conn: conn} do diff --git a/test/aprsme_web/live/map_live/movement_test.exs b/test/aprsme_web/live/map_live/movement_test.exs index 78dd44c..de8c973 100644 --- a/test/aprsme_web/live/map_live/movement_test.exs +++ b/test/aprsme_web/live/map_live/movement_test.exs @@ -18,6 +18,8 @@ defmodule AprsmeWeb.MapLive.MovementTest do test "does not update marker for GPS drift", %{conn: conn} do # Start with initial location {:ok, view, _html} = live(conn, "/", on_error: :warn) + # Help dialyzer narrow the View type + assert %{ref: _} = view # First update the map state to set zoom level assert render_hook(view, "update_map_state", %{ @@ -76,6 +78,9 @@ defmodule AprsmeWeb.MapLive.MovementTest do # Start with initial location at a zoom level that shows individual markers {:ok, view, _html} = live(conn, "/?z=15", on_error: :warn) + # Help dialyzer narrow the View type + assert %{ref: _} = view + # Notify the map is ready assert render_hook(view, "map_ready", %{}) diff --git a/test/aprsme_web/live/map_live/url_params_test.exs b/test/aprsme_web/live/map_live/url_params_test.exs index 06f1e47..2b02452 100644 --- a/test/aprsme_web/live/map_live/url_params_test.exs +++ b/test/aprsme_web/live/map_live/url_params_test.exs @@ -68,7 +68,6 @@ defmodule AprsmeWeb.MapLive.UrlParamsTest do describe "defaults" do test "default_center returns USA-centered coordinates" do %{lat: lat, lng: lng} = UrlParams.default_center() - assert is_float(lat) and is_float(lng) assert lat >= 25 and lat <= 50 assert lng >= -125 and lng <= -66 end diff --git a/test/aprsme_web/live/packets_live/index_test.exs b/test/aprsme_web/live/packets_live/index_test.exs index 5eb7349..de98094 100644 --- a/test/aprsme_web/live/packets_live/index_test.exs +++ b/test/aprsme_web/live/packets_live/index_test.exs @@ -2,8 +2,6 @@ defmodule AprsmeWeb.PacketsLive.IndexTest do use ExUnit.Case, async: true alias AprsmeWeb.PacketsLive.Index - alias Phoenix.LiveView.LiveStream - alias Phoenix.LiveView.Socket describe "extract_coordinate/2" do test "extracts lat from direct :lat key" do diff --git a/test/aprsme_web/telemetry_test.exs b/test/aprsme_web/telemetry_test.exs index 62d3dfa..90267c9 100644 --- a/test/aprsme_web/telemetry_test.exs +++ b/test/aprsme_web/telemetry_test.exs @@ -7,7 +7,7 @@ defmodule AprsmeWeb.TelemetryTest do test "returns a non-empty list of metric definitions" do metrics = Telemetry.metrics() assert is_list(metrics) - refute metrics == [] + refute Enum.empty?(metrics) end test "includes Phoenix endpoint, router, and live_view metrics" do diff --git a/test/support/aprs_is_mock.ex b/test/support/aprs_is_mock.ex index b43faa8..0f9882c 100644 --- a/test/support/aprs_is_mock.ex +++ b/test/support/aprs_is_mock.ex @@ -6,8 +6,6 @@ defmodule AprsIsMock do use GenServer - require Logger - def start_link(opts \\ []) do GenServer.start_link(__MODULE__, opts, name: __MODULE__) end